SD Card usermod: Adjust SPI configuration for ESP32-S3 support - #5679
Open
Will-wastelander wants to merge 698 commits into
Open
SD Card usermod: Adjust SPI configuration for ESP32-S3 support#5679Will-wastelander wants to merge 698 commits into
Will-wastelander wants to merge 698 commits into
Conversation
… doesn't get accidentally locked during setup
Add explicit guidance explaining that a unique USERMOD_ID_* is only needed when a usermod uses inter-mod communication, pin ownership via pinManager, or needs to be identifiable in JSON info output. Updates both AGENTS.md and the const.h comment block to reflect this.
Added section on accessibility and interaction for the WLED web UI.
Clarify target browser/platform combinations for WLED web UI.
Fix topLED fallrate not responding to "Rate of fall" slider.
Two issues prevented this usermod from building under v16:
1. library.json is missing "build": {"libArchive": false}, causing the
build system to reject it with an error before compilation begins.
2. serializeConfig() no longer has a no-argument overload in v16; the
working replacement is serializeConfigToFS() which creates the JSON
document internally and writes to the filesystem.
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Small helper for integrators by compile-time sanity checks: * WLED_NUM_ETH_TYPES is aligned with the boards table * WLED_ETH_DEFAULT is aligned with the boards table -> can be merged into 17.0.0, 16.0.0, and 0.15.x branch
Add sanity checks for ethernet config table and WLED_ETH_DEFAULT
…ocols (wled#5547) * less restrictive DDP header acceptance, add safety checks to all protocols * another check for malformed packet * clamp dmxChannels to MAX_CHANNELS_PER_UNIVERSE * bugfix in data length calculation * bugfix in parsePacket(): accept short artned packets
Apply boot preset in setup() so it's guaranteed to be active before the first frame is rendered.
…tive when "Use main segment only" (wled#5599) * fixes a minor problem with newer realtime modes (DDP, TPM2NET and DMX) not causing auto-suspend of sound processing. * ensure that AR audio stays active when "Use main segment only" (other segments are still controlled locally) * small update for better compatibility with V5 builds
Updated bug report template to discourage AI-generated error analyses.
Clarify PSRAM availability check instructions and usage.
Added PSRAM guidelines including availability checks, DMA compatibility, fragmentation considerations, and performance recommendations.
esp32s3_8MB_none, esp32s3_4M_none
tasmota core does not support "dio" mode on S3
missed a few ones
"esp32/rtc.h": Header file is deprecated, please include esp_rtc_time.h instead
* use older "compat" platform * use older "compat" libs
On 8266, compiling with WLED_SAVE_RAM increases flash size by 1.2KB, while reducing static RAM by 20KB only. Plus it reduves the size of the transition struct by 48 bytes (from 80 to 32). In the other side, the WLED_SAVE_RAM special code is not maintained, it introduces a slowdown, and its largely untested with the latest codebase. I suggest to remove this micro-optimization.
the NPB "core3" branch should only be used in V5 builds. Use the previous NPB version for V4 builds.
small cleanup: remove outdated warning notice
* disable build_type = debug (causes stack smashing in ArduinoJSON) * refine no-flto flags * remove "-Os" (already set by pioarduino) * add lib_ignore * remove AR usermod (causes bootloop)
legacy ADC driver cannot be used in V5
remove unmaintained WLED_SAVE_RAM On 8266, compiling with WLED_SAVE_RAM increases flash program size by 1.2KB, while reducing static RAM by 20 bytes only. Plus it reduces the size of the Segment::Transition struct by 48 bytes (from 80 to 32), by avoiding a separate palette for blending. On the other side, the WLED_SAVE_RAM special code is not maintained (corner case, needs a special build flag to activate), and its largely untested with the latest codebase.
fallback option for user who want audioreactive on ethernet boards.
wled_metadata.cpp currently does not receive WLED_REPO and WLED_VERSION. replace with dummy values for development.
quick workaround for bootloops observed when running a build that includes IR support
esp_dmx crashes during library initialization
will only happen when the version string is very long
* add getPinOwnerText to debug output * avoid using an invalid UART number for S2 and C3/C5/C6
problem: DmxVersionString was destroyed when createConfig() returns, so software_version_label became dangling already before dmx_driver_install(inputPortNum, &config, ...) consumes the configuration on Line 151 workaround: give the string static lifetime, so it stays valid after the function returns (MT-safe because the version does not change while WLED runs)
ensure that the VERSION macro is treated as unit32_t.
…5 builds (wled#5749) * Fix bootloop on C3 and S3 and ESP32 * , remove stray -DCO flags * fix AR usermod on ESP32 by adding stubs to legacy ADC driver is not pulled in * fix ID generation for all targets, add efuse entropy for new chips * add missing include just in case (seems not necessary for tested C6) * re enable AR on ESP32 as bootloop is fixed --------- Co-authored-by: Frank <91616163+softhack007@users.noreply.github.com>
* initial version, fully reviewed but untested * add support for missing RSSI in IDF V4 * optimize: make sending more robust * add namespace, move to lib\ * volatile -> atomic plus some comment cleanup * fix & simplify sending function, fix for ESP8266 * remove stray DCO again, enable espnow on C6 (tested working) and C5 (assumed working) * fix signature of espnowSentCB for IDF V5.5, comments, P4 compile fix * fix esp8266_2m_min env
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for ESP32-S3
[SD Card] usermod loaded Listing directory: / DIR : System Volume Information FILE: test.txt SIZE: 0Summary by CodeRabbit
-D UM_SD_SELECT,-D UM_SD_CLOCK,-D UM_SD_POCI,-D UM_SD_PICO).platformio_override.inisample template for per-target SD configuration.