Fix CTAP2 test compile issues for jCardSim - #20
Open
wl336 wants to merge 1 commit into
Open
Conversation
Owner
Author
|
Codex couldn't complete this request. Try again later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ECKey.getSize()which is not present under the testing environment and instead use the compatibleKey.getSize()API.Description
final short keyAgreementKeyLen = RESIDENT_KEY_CURVE_PARAMS.getKeyLength();inconsumeKeyAgreementto drive CBOR key parsing and avoid out-of-scope symbol errors inFIDO2Applet.ECKeywith a cast toKeywhen callinggetSize()inensureCredentialKeyPairto be compatible with jCardSim.src/test/java/us/q3q/fido2/AppletCtapCredentialTest.javathat implementsGetInfo,makeCredential, andgetAssertiontests acrossES256/ES384/ES512and its lightweight CBOR/COSE helpers.Testing
./gradlew test --tests us.q3q.fido2.AppletCtapCredentialTestwhich compiled successfully and proceeded to run tests, but the run was interrupted before completion (execution did not finish).FIDO2Appletare resolved by the code changes (no compilation failures reported during the test invocation).Codex Task