Skip to content

Fix CTAP2 test compile issues for jCardSim - #20

Open
wl336 wants to merge 1 commit into
dev_ecc_384_512from
codex/add-tests-for-makecredential/getassertion
Open

Fix CTAP2 test compile issues for jCardSim#20
wl336 wants to merge 1 commit into
dev_ecc_384_512from
codex/add-tests-for-makecredential/getassertion

Conversation

@wl336

@wl336 wl336 commented Jan 8, 2026

Copy link
Copy Markdown
Owner

Motivation

  • The newly added CTAP2 credential tests introduced compilation failures due to references to symbols and APIs that were not available under the jCardSim/testing build.
  • Ensure the authenticator code parses DH key agreement CBOR payloads using an in-scope key length value instead of relying on a variable out of scope.
  • Avoid using ECKey.getSize() which is not present under the testing environment and instead use the compatible Key.getSize() API.

Description

  • Added a local final short keyAgreementKeyLen = RESIDENT_KEY_CURVE_PARAMS.getKeyLength(); in consumeKeyAgreement to drive CBOR key parsing and avoid out-of-scope symbol errors in FIDO2Applet.
  • Replaced the cast to ECKey with a cast to Key when calling getSize() in ensureCredentialKeyPair to be compatible with jCardSim.
  • Included the large integration/unit test file src/test/java/us/q3q/fido2/AppletCtapCredentialTest.java that implements GetInfo, makeCredential, and getAssertion tests across ES256/ES384/ES512 and its lightweight CBOR/COSE helpers.

Testing

  • Ran ./gradlew test --tests us.q3q.fido2.AppletCtapCredentialTest which compiled successfully and proceeded to run tests, but the run was interrupted before completion (execution did not finish).
  • Verified that the previous compilation errors in FIDO2Applet are resolved by the code changes (no compilation failures reported during the test invocation).
  • No new automated test failures were observed prior to the interrupted run.

Codex Task

@wl336

wl336 commented Jan 13, 2026

Copy link
Copy Markdown
Owner Author

@codex

Repository owner deleted a comment from chatgpt-codex-connector Bot Jan 13, 2026
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex couldn't complete this request. Try again later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant