WPB-28709 additional logging on failed mls commits - #5544
Merged
battermann merged 4 commits intoSep 18, 2026
Merged
Conversation
- unexpected exception during the protected commit operation; - unexpected exception during lock release;
battermann
marked this pull request as ready for review
September 18, 2026 07:52
zebot
added
the
ok-to-test
Contributor
There was a problem hiding this comment.
馃煛 Changes recommended
Generic error rendering exposes raw MLS diagnostics in logs, and acquisition exceptions bypass the added commit-lock context.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds diagnostic logging for failed MLS commit-bundle operations and commit-lock handling.
Changes:
- Logs typed MLS commit failures.
- Logs commit-lock operation and release failures with context.
- Adds a changelog entry.
File summaries
| File | Description |
|---|---|
libs/wire-subsystems/src/Wire/ConversationSubsystem/MLS/Util.hs |
Adds commit-lock failure logging. |
libs/wire-subsystems/src/Wire/ConversationSubsystem/Interpreter.hs |
Logs typed MLS commit errors. |
changelog.d/5-internal/WPB-28709 |
Documents the diagnostic logging. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 2
- Review effort level: Lite
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
fisx
approved these changes
Sep 18, 2026
battermann
deleted the
WPB-28709-additional-logging-on-failed-mls-commits
branch
September 18, 2026 11:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
changelog.d