WPB-27964 use CSP header of account pages - #5534
Conversation
zebot
added
the
ok-to-test
There was a problem hiding this comment.
馃煛 Changes recommended
The new ingress snippet references config.dns.accountPages unconditionally, which can render <no value> when account-pages is disabled or unset and should be guarded/validated.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates the nginx-ingress-services Helm chart to avoid setting the chart-generated CSP header for the account-pages host, so account-pages can supply its own CSP in multi-ingress setups.
Changes:
- Skip ingress-level CSP injection when the request host matches
config.dns.accountPages. - Add a changelog entry documenting the multi-ingress CSP/backend URL fix.
File summaries
| File | Description |
|---|---|
| charts/nginx-ingress-services/templates/ingress.yaml | Adds host-based CSP-skip logic for account-pages in the nginx configuration snippet. |
| changelog.d/3-bug-fixes/WPB-27964 | Documents the fix for account-pages CSP/backend URL behavior on multi-ingress domains. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
馃煛 Changes recommended
The Helm template currently contains a quoting error in the new required expression that will break chart rendering.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
There was a problem hiding this comment.
馃煛 Changes recommended
The integration values omit config.dns.base, causing Helm rendering to fail at the required lookup.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 8/8 changed files
- Comments generated: 1
- Review effort level: Lite
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
should be merged after: https://github.com/zinfra/cailleach/pull/4956
https://wearezeta.atlassian.net/browse/WPB-27964
Checklist
changelog.d