Skip to content

feat: add apps and collaborators to team sync [WPB-28428] - #5249

Open
ikotarac wants to merge 1 commit into
developfrom
feat/add-apps-and-collaborators-to-team-sync
Open

feat: add apps and collaborators to team sync [WPB-28428]#5249
ikotarac wants to merge 1 commit into
developfrom
feat/add-apps-and-collaborators-to-team-sync

Conversation

@ikotarac

@ikotarac ikotarac commented Sep 3, 2026

Copy link
Copy Markdown

https://wearezeta.atlassian.net/browse/WPB-28428

https://wearezeta.atlassian.net/browse/WPB-28428

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

https://wearezeta.atlassian.net/browse/WPB-28428

  • clients are not able to show external apps to add them to conversations. External apps are returned by backend call /teams/:tid/collaborators
  • internal apps are currently returned by /teams/:tid/members which will change because treating apps as team members incorrectly contributes to used seat count, that's why we need to add call to /teams/:tid/apps to fetch internal apps as well

Solutions

This is a diagram of how different endpoints return different schemas, and how they all map to AppEntity in the end.

Screenshot 2026-09-03 at 17 24 26

This PR fetches collaborators and apps as part of SlowSyncWorker, analogous to the way team members are currently fetched.

Needs releases with:

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

Added unit tests in TeamRepositoryTest and SyncSelfTeamUseCaseTest.

How to Test

Tested

Tested manually by clearing app data and then logging in to staging team, and verifying that internal and external apps are correctly shown. Inspected local database and network in app inspection to confirm that collaborators and apps are correctly fetched and stored.

Attachments (Optional)

Screen_recording_20260903_104106.mp4

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.03%. Comparing base (cb21638) to head (b5e8488).

⚠️ Current head b5e8488 differs from pull request most recent head f7da1a5

Please upload reports for the commit f7da1a5 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5249      +/-   ##
===========================================
- Coverage    53.04%   53.03%   -0.01%     
===========================================
  Files          745      745              
  Lines        25824    25824              
  Branches      4236     4236              
===========================================
- Hits         13698    13697       -1     
  Misses       10792    10792              
- Partials      1334     1335       +1     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb21638...f7da1a5. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Test Results

40 tests   - 2 628   40 ✅  - 2 628   3s ⏱️ - 1m 42s
 8 suites  -   330    0 💤 ±    0 
 8 files    -   330    0 ❌ ±    0 

Results for commit f7da1a5. ± Comparison against base commit cb21638.

This pull request removes 2628 tests.
com.wire.android.GlobalObserversManagerTest ‑ given app not visible and valid session, when handling ephemeral messages, then do not call deleteEphemeralMessageEndDate()
com.wire.android.GlobalObserversManagerTest ‑ given app not visible and valid session, when observing app open, then do not retry sending pending messages()
com.wire.android.GlobalObserversManagerTest ‑ given app visible and invalid session, when app opens, then do not retry sending pending messages()
com.wire.android.GlobalObserversManagerTest ‑ given app visible and invalid session, when handling ephemeral messages, then do not call deleteEphemeralMessageEndDate()
com.wire.android.GlobalObserversManagerTest ‑ given app visible and no session, when app opens, then do not retry sending pending messages()
com.wire.android.GlobalObserversManagerTest ‑ given app visible and no session, when handling ephemeral messages, then do not call deleteEphemeralMessageEndDate()
com.wire.android.GlobalObserversManagerTest ‑ given app visible and session failure, when app opens, then do not retry sending pending messages()
com.wire.android.GlobalObserversManagerTest ‑ given app visible and session failure, when handling ephemeral messages, then do not call deleteEphemeralMessageEndDate()
com.wire.android.GlobalObserversManagerTest ‑ given app visible and valid session, when app opens, then retry sending pending messages()
com.wire.android.GlobalObserversManagerTest ‑ given app visible and valid session, when handling ephemeral messages, then call deleteEphemeralMessageEndDate()
…

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@ikotarac
ikotarac force-pushed the feat/add-apps-and-collaborators-to-team-sync branch from b5e8488 to f7da1a5 Compare September 3, 2026 16:23
@ikotarac ikotarac changed the title feat: Add apps and collaborators to team sync [WPB-28428] feat: add apps and collaborators to team sync [WPB-28428] Sep 3, 2026
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

@ikotarac looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
a1552ff4ba856589bb3662b6e3ca6ca28997a55e 084fa3e6b6293a6ca1d68bfcd3e9833b87f89097

Is this intentional?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants