Skip to content

feat(drive): Restrict external file opening for Viewer users (WPB-28476) - #5247

Open
ohassine wants to merge 2 commits into
developfrom
restrict-opening-files-by-external-apps
Open

feat(drive): Restrict external file opening for Viewer users (WPB-28476)#5247
ohassine wants to merge 2 commits into
developfrom
restrict-opening-files-by-external-apps

Conversation

@ohassine

@ohassine ohassine commented Sep 3, 2026

Copy link
Copy Markdown
Member

https://wearezeta.atlassian.net/browse/WPB-28476


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Prevent users with the Viewer role from opening files using external apps when Drive permissions are enabled.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 44.44444% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.03%. Comparing base (cb21638) to head (942d82c).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...com/wire/android/feature/cells/ui/CellViewModel.kt 44.44% 4 Missing and 6 partials ⚠️

❌ Your patch check has failed because the patch coverage (44.44%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5247      +/-   ##
===========================================
- Coverage    53.04%   53.03%   -0.02%     
===========================================
  Files          745      745              
  Lines        25824    25831       +7     
  Branches      4236     4240       +4     
===========================================
+ Hits         13698    13699       +1     
- Misses       10792    10794       +2     
- Partials      1334     1338       +4     
Files with missing lines Coverage Δ
...com/wire/android/feature/cells/ui/CellViewModel.kt 47.47% <44.44%> (-0.60%) ⬇️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb21638...942d82c. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Test Results

2 668 tests  ±0   2 668 ✅ ±0   1m 43s ⏱️ -2s
  338 suites ±0       0 💤 ±0 
  338 files   ±0       0 ❌ ±0 

Results for commit 942d82c. ± Comparison against base commit cb21638.

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants