minor refactoring and CI update#146
Open
maurerle wants to merge 9 commits into
Open
Conversation
Assisted-by: gemini-3.1-pro
- actions/checkout: v3 -> v7 - actions/setup-python: v4 -> v6 - conda-incubator/setup-miniconda: v2 -> v4 Assisted-by: gemini-3.1-pro
No released version of pytest-notebook is compatible with pytest 8+ — all versions still declare 'path' in the pytest_collect_file hookimpl, which was removed from the hookspec in pytest 8. This causes a PluginValidationError at startup and prevents any tests from running. The notebook tests in example/test_examples.py are already excluded from the testpaths in pytest.ini, so removing this dependency does not affect CI coverage. Assisted-by: gemini-3.5-flash
… directories Assisted-by: gemini-3.5-flash
Use lowercase frequency 'h' instead of 'H' and use .iloc[0] instead of [0] on DatetimeIndex. Assisted-by: gemini-3.5-flash
The OpenEnergyPlatform (OEP) API URL changed from oep.iks.cs.ovgu.de to openenergyplatform.org. The test_wrong_url_load_turbine_data test is also updated to use an invalid table 'wrong_table' rather than 'wrong_schema' because the OEP API now returns 200 OK for invalid schemas. Assisted-by: gemini-3.5-flash
The OEDB database currently contains more than 20% faulty turbine data entries. Setting the threshold to 1.0 forces the downloaded data to be saved to disk, ensuring that the file modification timestamp check passes. Assisted-by: gemini-3.5-flash
maurerle
force-pushed
the
refactor-closest-height
branch
from
d0fe639 to
e4b9a27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extract _get_closest_height helper to reduce code duplication
remove legacy object inheritance from classes as this is a python 2 relict