Repository navigation
Conversation
issueListCount reduces the list's filters (filterListQuery, now shared with buildListQuery as in TS) to a count(). The drift test has samples of it and no longer exempts it. The list's toolbar shows the count once the server has it, and the list's running total before, as the list page does. Co-authored-by: tmm <tmm@tmm.dev> Amp-Thread-ID: https://ampcode.com/threads/T-01a19a37-5aa9-7256-bff5-cdc47c01a1fe
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 5 of 5 of the Swift aggregates port (plan). Stacked on #71.
issueListCountported. As in TS,filterListQuery(project, filters, creator, assignee and permissions) is now shared bybuildListQueryand the count, which reduces it with.count().DriftTestsnow expects no failures.issueListCount, so the drift test only checked that the name existed. Three samples now cover it (alice, crew with every filter, logged out), and the vectors were regenerated with the CLI's recorder. When I added an extrawhereto the Swift definition, the test failed with an AST difference.completeorcached, and the virtualizer's total (or its rounded estimate with+) before that, aslist-page.tsxdoes. A text search isn't counted, matching the web app.Checks run locally: zbugs builds and its 5 tests pass (drift included), and swift-format lint is clean. ZBugsUI only builds on Apple platforms, so the macOS app build and the screenshots job are the signal for the toolbar item.
There's no changeset because this only changes an app.