Repository navigation
fix(demo): separate Material You and dark mode toggles - #73
Merged
Merged
Conversation
Contributor
Playwright test results
Details
|
Contributor
|
📊 Ionic 9 Playwright Test Report View the detailed Ionic 9 report: https://webview-native-ui.github.io/ionic-theme-md3/pr-73/ Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run. |
Contributor
npm beta publishedCI passed for the merge commit npm install @rdlabo/ionic-theme-md3@9.2.0-beta.pr73.shabdf74792a442 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the demo's System/Light/Dark buttons with independent Material You and Dark Mode toggles, following the original dark-mode toggle UI. Dark Mode defaults to light; Material You keeps its current enabled default. Turning Material You off restores standard colors while preserving the selected appearance, and turning it back on applies that appearance's device palette.
The toggles bind to a shared settings signal through Signal Forms (
form()and[formField]). A component effect applies settings to the imperative theme API; only Material You changes refresh the device palette.Read the native palette availability rather than assuming every Android device supports Material You. Unsupported devices, Web/iOS, and native builds missing the API show Material You as off and disabled with an explanation. Dark Mode remains available. Signal Forms owns the disabled state.
Validation:
Visual regression baselines were not regenerated locally.
Supervisor and independent third-party acceptance reviews completed; all requested corrections were re-reviewed and approved.