Repository navigation
feat: simplify MD3 theme setup - #72
Merged
Merged
Conversation
Contributor
Playwright test resultsDetails
|
Contributor
|
📊 Ionic 9 Playwright Test Report View the detailed Ionic 9 report: https://webview-native-ui.github.io/ionic-theme-md3/pr-72/ Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run. |
Contributor
npm beta publishedCI passed for the merge commit npm install @rdlabo/ionic-theme-md3@9.2.0-beta.pr72.sha304629710b80 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applications currently assemble individual theme stylesheets and wire animation exports into Ionic configuration. This adds a high-level setup path within the MD3 package.
md3ThemeConfigis anIonicConfigobject spread into the existing initializer. The application owns composition and overrides, with minimal examples showing optional settings as comments.styles/theme.csscombines MD3 variables and component styles. Applications retain their chosen Ionic dark palette.Existing stylesheet paths and individual animation exports remain supported.
Validation
skipLibCheck: truebecause upstream Ionic declarations contain an IonicVue IonIcon path error and an Ionic 8 DOM autocorrect conflict.