Repository navigation
fix: preserve Material foreground pairs in Ionic colors - #67
Merged
Merged
Conversation
Contributor
Author
|
/update-screenshots |
Contributor
|
❌ Failed to update screenshots. Please check the workflow run for details. |
Contributor
Playwright test resultsDetails
|
Contributor
Author
|
/update-screenshots |
Contributor
|
📊 Ionic 9 Playwright Test Report View the detailed Ionic 9 report: https://webview-native-ui.github.io/ionic-theme-md3/pr-67/ Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run. |
Contributor
|
✅ Screenshots have been updated successfully! The new screenshots have been committed to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a device supplies Material You foreground roles, explicitly colored Ionic components currently replace them with calculated black/white contrast colors. Map
onPrimary,onSecondary,onTertiaryandonErrorto the corresponding primary/secondary/tertiary/danger contrast and contrast-RGB variables.Missing roles independently retain Ionic's existing contrast calculation, including when optional roles disappear after refresh. Backgrounds, neutral palettes, shade/tint calculations, success and warning are unchanged. Update the guide, bridge-color assertions, and add unit and rendered button/card coverage. The rendered test uses components registered by the demo page.
Validation:
c412a48200dbcc77fe6134a6bb7ace7cc360ed6f; installed published 2.1.1 did not expose the native getter. A separate app ID preserved the existing demo. Local Android build overrides are excluded.Screenshot baselines are regenerated through CI via
/update-screenshots; local golden images were not overwritten. Physical verification covers the color pairs, not a full device UI review.During final CI validation, an existing searchbar test counted inputs before Ionic rendered them. It now waits for an input per searchbar; 10 local repetitions passed with retries disabled. CI now fails on flaky tests rather than accepting retry-only passes. This changes test synchronization only; production searchbar CSS is unchanged.
CI regenerated the baseline images, which were visually compared. The meaningful changes are foreground colors on device-colored components; the default segment/toggle baselines also contain seven pixels of rendering variation in total.