Repository navigation
Conversation
Contributor
Author
|
/update-screenshots |
Contributor
|
ℹ️ No screenshot changes detected. The current screenshots are already up to date. |
Contributor
Playwright test results
Details
|
Contributor
|
📊 Ionic 9 Playwright Test Report View the detailed Ionic 9 report after GitHub Pages deployment completes: https://webview-native-ui.github.io/ionic-theme-ios27/pr-367/ View the results in the workflow run. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A custom datetime Modal with component-scoped
ion-modal { --width: auto; --height: auto; }still received the theme's fixed desktop dimensions, leaving a large empty frame around the picker. The example supplied in #361 uses this path rather thanion-datetime-button.Lower the specificity of dimension defaults so explicit component CSS can override them. Preserve the existing positioning, decoration and sheet-offset precedence. No extra picker class is required.
Both screenshots use the same fixture and 1200 × 800 viewport in Linux/amd64 Playwright 1.58.2; only the theme CSS changes.
Validation
CI: all 571 E2E tests passed; the screenshot-update workflow reported no changes.
Linux: 27 tests passed, including 14 datetime screenshots and 13 existing Modal tests. The original eight datetime baselines are unchanged.
Existing floating-sheet tests also cover an 80px offset and bottom alignment.
Ionic 8.8.19: six sizing checks passed across desktop, folded and phone layouts, with component CSS loaded before or after the theme.
Build and lint passed; supervisor and independent acceptance reviews completed without outstanding changes.
Related to #361.