Repository navigation
fix: preserve content-sized datetime modals - #366
Merged
Merged
Conversation
Contributor
Playwright test results
Details
|
Contributor
|
📊 Ionic 9 Playwright Test Report View the detailed Ionic 9 report after GitHub Pages deployment completes: https://webview-native-ui.github.io/ionic-theme-ios27/pr-366/ View the results in the workflow run. |
Contributor
Author
|
/update-screenshots |
Contributor
|
ℹ️ No screenshot changes detected. The current screenshots are already up to date. |
Contributor
npm beta publishedCI passed for the merge commit npm install @rdlabo/ionic-theme-ios27@2.1.1-beta.pr366.sha55488bcd3b80 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Datetime Button modals inherit the theme's desktop modal dimensions, leaving a large empty area around the picker. Exclude Ionic's
ion-datetime-button-overlayfrom the desktop and foldable modal sizing rules so Ionic's existingfit-contentsizing remains effective, including custom picker widths. Keep selector specificity unchanged so consumer CSS can still override normal modal sizes.This changes modal sizing only. Normal, card and sheet modals keep their existing layout; datetime buttons and popover behavior are unchanged. Related to #361.
Validation:
/update-screenshotsand reported no changes; both E2E shards passed.Before / After
Same demo page: Ionic 9.0.0, Chromium on Linux/amd64, 1200 × 800 viewport. The picker remains 320 × 320; the modal changes from 580 × 660 to the same 320 × 320.