Repository navigation
Conversation
rdlabo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bundled Controls renderer selected snapshot source views from a dictionary. A partial selection could paint overlapping controls in a different order, or reuse an old image after the native stacking order changed. The image handed to Web must preserve the native appearance.
Select requested views in the host's native drawing order, retaining the existing fallback for sources outside that host. The regression test compares decoded pixels across repeated handoffs and after changing the stacking order.
This change belongs to the Controls renderer. Engine capture APIs, settling, PNG/color handling and Web handoff scheduling remain unchanged.
Validation
CI: lint, Rust, browser, Swift and Android checks passed.
The unchanged main controller fails the stacking-order pixel regression; the fix passes.
Swift package: 96 tests, one hosted-only skip, no failures; three hosted Controls tests passed.
Controls image-handoff tests: 52 passed; browser projection tests: 84 passed.
Real simulator image-pipeline verification passed, including reuse, content invalidation and file cleanup.
TypeScript, ESLint, Prettier, SwiftLint and package verification passed.