Repository navigation
perf: encode native snapshots with Rust and reuse prepared images - #46
Merged
Merged
Conversation
…nt and reordering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native snapshot handoffs repeatedly encoded PNGs and decoded unchanged images. This PR adds a packaged Rust PNG encoder, bounded two-worker postprocessing, and reuse of eligible captures/files/decoded images. Consumers do not need Rust or an NDK.
Performance
Total time includes capture readiness, capture, copies/FFI, PNG encoding, file transport, Web image decode and drawing confirmation. Each comparison interleaved modes, excluded three warmup rounds, and measured 30 fresh captures per mode on a 12-control screen.
Platform encoder → serial Rust encoder
Serial Rust → two-worker Rust (same codec/settings)
These are separate experiments; their reductions must not be added. PNG size changes by +2.3% on iOS and −15.2% on Android in the encoder comparison, and is unchanged between worker modes. These fixture results are not physical-device or universal speedup claims; Android's final p90 concurrency improvement is small.
Behavior and correctness
Local validation: TypeScript/ESLint/format checks, native artifact verification, iOS image-reuse integration, and Android Kotlin formatting/Release lint passed. Four Android emulator regressions passed, including common translation, relative movement, draw-order changes and comparison against fresh-capture pixels.