Repository navigation
fix: unify moving-surface image handoffs - #45
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving DOM surfaces used a separate image-transfer sequence that could expose live translucent controls beneath their Web images and misalign cached captures with later layout.
Use the common cover/painted and restore/accepted-update handoff for all surfaces, including temporary Native copies on iOS and Android. Add optional capture-relative anchor bounds and a generic layout adapter so placement can change without controlling visibility or capturing again during transfer. Keep active image ownership separate from cache reuse, and remove the unreleased staged-return API and its dedicated state.
Update the handoff documentation and regression tests for delayed acknowledgements, immediate reversal, capture-relative placement, and Android image-copy painting and retirement. No Modal, Ionic, or device-specific layout rules are added to Engine.
Validation: lint, build, projection browser tests, controls tests, native handoff tests, release tests, and package verification passed. Supervisor and independent acceptance reviews found no remaining blocking findings.
Transparent images can still briefly double-composite their edges during transfer; this change does not claim pixel-identical Liquid Glass rendering or resolve that remaining visual limitation.