Skip to content

fix: authenticate GitHub API requests and remove outdated release TODOs #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avivkeller merged 2 commits into from
Aug 21, 2026
+7 −4
Merged

fix: authenticate GitHub API requests and remove outdated release TODOs #252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
827cbb3
docs: remove TODO notes from Webpack 5 release post
moshams272 Aug 20, 2026
3acbaff
fix(scripts): spread githubHeaders to authenticate API requests and h…
moshams272 Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pages/blog/posts/2020-10-10-webpack-5-release.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1066,7 +1066,7 @@ That means the following information about modules has been moved:

- Module connections -> ModuleGraph
- Module issuer -> ModuleGraph
- Module optimization bailout -> ModuleGraph (TODO: check if it should ChunkGraph instead)
- Module optimization bailout -> ModuleGraph
- Module usedExports -> ModuleGraph
- Module providedExports -> ModuleGraph
- Module pre order index -> ModuleGraph
Expand Down Expand Up @@ -1257,8 +1257,8 @@ These dependencies are cheaper to process and webpack uses them when possible
- `Chunk.getChunkModuleMaps` is deprecated
- `Chunk.hasModuleInGraph` is deprecated
- `Chunk.updateHash` signature changed
- `Chunk.getChildIdsByOrders` signature changed (TODO: consider moving to `ChunkGraph`)
- `Chunk.getChildIdsByOrdersMap` signature changed (TODO: consider moving to `ChunkGraph`)
- `Chunk.getChildIdsByOrders` signature changed
- `Chunk.getChildIdsByOrdersMap` signature changed
- `Chunk.getChunkModuleMaps` removed
- `Chunk.setModules` removed
- deprecated Chunk methods removed
Expand Down
3 changes: 3 additions & 0 deletions scripts/markdown/readmes.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ const discoverRepos = async () => {

while (url) {
const res = await fetchWithAuth(url);
if (!res.ok) {
throw new Error(`GitHub API returned ${res.status}: ${await res.text()}`);
}

for (const repo of await res.json()) {
if (repo.archived) continue;
Expand Down
2 changes: 1 addition & 1 deletion scripts/utils/fetch.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ export const fetchWithAuth = (url, fetchOptions = {}, retryOptions) =>
...fetchOptions,
headers: {
...fetchOptions?.headers,
githubHeaders,
...githubHeaders,
Comment thread
moshams272 marked this conversation as resolved.
},
},
retryOptions
Expand Down