Repository navigation
docs(selenium-devtools): describe the Safari focus handling the adapter has - #438
Merged
Merged
Conversation
…er has The Limitations bullet said the plugin runs `open -a Safari` once after the session starts. That is what the WDIO service, Nightwatch and the Python adapter do; the Selenium adapter instead switches to the session's own window before each element input when it has lost focus, and opens the dashboard behind Safari on macOS. Users reading the README were told about a mechanism this adapter does not use. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
 [Low impact] This documentation-only change appears safe to merge. SummaryCorrects the Selenium README’s explanation of Safari focus handling.
Reviews (1) · Last reviewed commit: "docs(selenium-devtools): describe the Sa..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Selenium README's Limitations bullet said the plugin brings Safari to the front once after the session starts with `open -a Safari`. That is the WDIO service, Nightwatch and Python behaviour (`restoreBrowserFocus`), not Selenium's.
The bullet now matches the code: before each element click, `sendKeys`, `clear` or `submit` on a Safari session, `focusForInput` (wired as the driver patcher's `beforeInput` hook) switches to the session's own window handle when that window has lost focus and the test is in the top-level document, and `dashboardLaunchCommand` opens the dashboard behind Safari on macOS. The advice to avoid clicking other windows during a live Safari run, and the note that trace mode is unaffected, are kept.
README only, so no changeset.
🤖 Generated with Claude Code