Skip to content

Async chunk loading for spigot/paper 1.21.3/1.21.4#4188

Merged
mikeprimm merged 2 commits into
webbukkit:v3.0from
ZockiRR:v3.0
Apr 1, 2025
Merged

Async chunk loading for spigot/paper 1.21.3/1.21.4#4188
mikeprimm merged 2 commits into
webbukkit:v3.0from
ZockiRR:v3.0

Conversation

@ZockiRR

@ZockiRR ZockiRR commented Feb 2, 2025

Copy link
Copy Markdown
Contributor

This PR brings back async chunk loading for spigot/paper 1.21.3/1.21.4 requested by #4185.

Basically the impl is described here:
#4164 (comment)

Tested on paper 1.21.4.

Let me know if anything else is needed.

@jacob1

jacob1 commented Feb 5, 2025

Copy link
Copy Markdown
Contributor

I loaded this on my server, and it's working fine. Although, I've never had major performance issues, so I can't really compare a before -> after. mspt seemed around the same, still generally low.

My server is Spigot 1.21.4, which confirms it works there too (Spigot didn't have async chunk loading before).

@ZockiRR

ZockiRR commented Feb 24, 2025

Copy link
Copy Markdown
Contributor Author

The PR has been updated. I hope all matters have been addressed properly.

I have not yet been able to test it myself with paper and hope to do so in the next few days.

@jacob1 would be great if you could test it again with spigot. Thanks in advance.

@jacob1 jacob1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I tested it on my server. It threw an exception, I gave a fix. With that fix, it works great.

@hmlendea

hmlendea commented Mar 7, 2025

Copy link
Copy Markdown

Is there a build artifact of this available anywhere? I'd like to test it on my server on which the latest Dynmap release causes lag.

@masmc05

masmc05 commented Mar 7, 2025

Copy link
Copy Markdown
Contributor

Is there a build artifact of this available anywhere? I'd like to test it on my server on which the latest Dynmap release causes lag.

It's a bad idea to download jars from random people, but you can easily compile
Here's the explanation: https://github.com/webbukkit/dynmap?tab=readme-ov-file#how-to-build
Basically first download the code (either use git to clone or use the big green "code" button then "Download code") then run gradle to compile (gradlew.bat setup build on windows or gradlew setup build for rest operating systems)

@ZockiRR

ZockiRR commented Mar 7, 2025

Copy link
Copy Markdown
Contributor Author

I fixed the NPE mentioned by @jacob1 and tested on paper. Should be good to go now.

@mikeprimm

Copy link
Copy Markdown
Member

Looks promising - thanks!!

@mikeprimm
mikeprimm merged commit 10e6739 into webbukkit:v3.0 Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants