Skip to content

chore: migrate hooks and staged tasks to Rstack CLI - #1885

Merged
chenjiahan merged 1 commit into
mainfrom
chenjiahan/chore-rstack-hooks-staged
Aug 30, 2026
Merged

chore: migrate hooks and staged tasks to Rstack CLI#1885
chenjiahan merged 1 commit into
mainfrom
chenjiahan/chore-rstack-hooks-staged

Conversation

@chenjiahan

Copy link
Copy Markdown
Member

Summary

This PR moves repository-level Git hooks and staged-file tasks to Rstack CLI so they use the same unified tooling as linting and formatting.

  • Install hooks with rs hooks and invoke rs staged from the pre-commit hook.
  • Preserve the existing staged globs and commands through define.staged(), while removing simple-git-hooks and nano-staged.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI lite review requested due to automatic review settings August 30, 2026 12:27
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 30, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-30T12:32:13.132814Z bd8f0c5 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates repository-level Git hooks and staged-file automation from simple-git-hooks + nano-staged to Rstack CLI (rs hooks / rs staged), consolidating tooling with the existing rs lint / rs fmt workflows used elsewhere in the repo.

Changes:

  • Add define.staged() rules in rstack.config.ts to preserve the existing staged globs and commands.
  • Switch hook installation to rs hooks via the root prepare script and add a repo hook that runs rs staged.
  • Remove simple-git-hooks / nano-staged from workspace catalogs and lockfile.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
rstack.config.ts Defines staged-file task configuration via define.staged() for rs staged.
package.json Replaces prepare: simple-git-hooks with prepare: rs hooks and removes old hook/task config blocks and deps.
.rstack/hooks/pre-commit Adds a repository-level pre-commit hook that runs rs staged.
pnpm-workspace.yaml Removes nano-staged / simple-git-hooks from catalogs and build allowlist.
pnpm-lock.yaml Removes nano-staged / simple-git-hooks entries from the lockfile.
Files not reviewed (1)
  • pnpm-lock.yaml: Generated file

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@chenjiahan
chenjiahan merged commit d89ed85 into main Aug 30, 2026
12 checks passed
@chenjiahan
chenjiahan deleted the chenjiahan/chore-rstack-hooks-staged branch August 30, 2026 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants