Conversation
Deploying midscene with
|
| Latest commit: |
92c8f63
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://76a29da7.midscene.pages.dev |
| Branch Preview URL: | https://feat-custom-wait-for-ready.midscene.pages.dev |
yuyutaotao
marked this pull request as draft
September 10, 2026 07:51
xiong35
marked this pull request as ready for review
September 11, 2026 03:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Navigation completion and fixed delays do not guarantee that an application's initial data and rendering are ready. Developers previously had no shared Agent option to define this readiness condition.
Add
waitForInitialPageReady: { handler, timeoutMs }to let developers control when the Agent can first read or operate on the page.AbortSignalfor cleanup on timeout or Agent destruction.Validation
91 unit tests passed across the selected Core and Web suites. Core and Web builds passed.
@codex summary and review