Repository navigation
fix: repair docs consistency audit and clarify Slack reporting - #943
Conversation
Ignore slash-only canonicalization when resolving redirect identities, preserve genuine cycle detection, and report audit outcomes with coverage and actionable next steps. Add safe early-failure artifacts, skill guidance, and regression coverage. Co-Authored-By: Warp <agent@warp.dev>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR updates the docs consistency audit skill and helper to ignore slash-only redirect canonicalization loops, add public-safe blocked-report artifacts, and improve Slack notification language for completed, partial, and blocked runs. The changed tests cover redirect normalization, blocked-report state handling, Slack markup escaping, partial/blocked resolution behavior, and notification output cases.
Concerns
- No blocking correctness, security, comment-quality, test-quality, or spec-alignment concerns were found in the annotated diff.
spec_context.mdreports that no approved or repository spec context was found, so there were no implementation-vs-spec commitments to enforce.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /warp-agent-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
There was a problem hiding this comment.
No blocking findings at 44b3325. All 12 checks pass; 60 regression tests and benchmarks passed. Verified complete, partial, and blocked rendering against the requester-provided Slack screenshot. Live scheduled-audit recovery was not exercised.
Responding as Docs Factory (V2): Open session · View in factory
Summary
Repair the docs consistency audit's redirect handling and make its Slack reports explain the outcome, coverage, and next action.
The October 21 audit stopped before extracting any pages. Its helper normalized
/agents→/agents/and/platform/environments→/platform/environments/into self-loops. Reproducing the recorded input checked 718 routes and produced 30 false cycle errors before this fix and zero after it.Changes
blocked-reportcommand for early failures that reads, but does not modify, prior state. Use controlled failure codes instead of raw exceptions.Slack message preview
Generated by the new formatter using the October 21 blocked-run context. This is a local preview, not a new audit result or a message posted to Slack. Slack's emphasis and link syntax are converted to GitHub Markdown for review.
Companion automation update
The same reporting structure is applied to the schema-audit automation in docs-factory-config PR #26. That separate diff changes reporting prompts only, not the checker or schedules; it is not included in this docs PR's code changes.
Factory configuration docs check preview
Illustrative message using the October 22 run's findings and the revised prompt. This is not a new audit result or a message posted to Slack.
The companion change passed 39 repository tests and 38 offline checker tests. Server parser validation passed; state-dependent apply checks and live Slack delivery were not run.
Validation
git diff --checkpassed.Rollout and scope
The audit remains detection-only. No public documentation claims, site redirects, schedules, or factory configuration changed. No live audit was triggered and no Slack message was posted. Live recovery still needs verification after merge.
The existing audit-state PR #876 remains a standing draft for findings and history, not a fixes PR to merge.
Unverified claims
No public product claims were added or changed. Scheduled execution and Slack delivery have not been tested live.
Documentation risk
Risk: low
Rationale: Internal Docs-team audit tooling and skill maintenance only; no public product claims or developer-facing commands are changed.
Docs override: none
Agent context
Investigation and approved implementation plan
Co-Authored-By: Warp agent@warp.dev