Repository navigation
Fix Warp notifications for detached Codex hooks - #6
Merged
Merged
Conversation
seemeroland
marked this pull request as ready for review
September 30, 2026 01:31
liliwilson
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore Warp lifecycle notifications when Codex runs hooks without a controlling terminal. Codex 0.155.0 introduced terminal detachment, so the previous
/dev/tty-only notifier could silently drop in-progress and completion updates even while prompts executed successfully.What changed
/dev/ttyas the first choice for compatibility with older Codex versions./procandreadlink, including minimal images withoutps; macOS usesps.This does not change plugin version metadata or the minimum-version pins in Warp. Existing cached installations need an explicit refresh; release rollout is separate.
Validation
Manually tested with e2e tests and oz-local:
Completed during implementation:
macOS PTY integration remains unverified: an isolated probe also hung without the plugin involved. Windows transport was not changed and PowerShell tests were not run locally.
Upstream behavior change: openai/codex#43876
CHANGELOG-APP: Fixed missing Codex status notifications when hooks run without a controlling terminal.
Agent conversation
Co-Authored-By: Warp agent@warp.dev