Conversation
The preview in on-permission-request.sh handles .command and .file_path and falls back to tostring[0:80] for everything else. For AskUserQuestion that fallback dumps raw JSON, so the notification truncates before the question itself. Add an elif branch for .questions, plus four tests covering Bash, Write, AskUserQuestion and the unknown-tool fallback. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…entries Transcript entries of type "user" are not only what the human typed. Background-task notifications, blocking-hook feedback, system reminders, messages from other sessions and subagent prompts all arrive under the same type, so taking the last one titled notifications like '<task-notification>\n<task...' finished An image-only message carries just "[Image: source: /path]", which titled the notification with a file path. Skip synthetic entries and sidechains, strip image markers, and fall back to the last real prompt. Six tests cover each shape. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
RomanBOGR
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two independent fixes to what Warp notifications say. Both are small, both come with tests — the affected expressions had no coverage before.
tests/test-hooks.sh: 67 passed, 0 failed.1.
AskUserQuestionpermission notifications show raw JSONon-permission-request.shbuilds its preview from.commandor.file_pathand falls back totostring[0:80]for everything else. ForAskUserQuestionthat fallback dumps the tool input:and truncates before the question itself. Adds an
elif .questionsbranch.2. Stop notifications are titled with synthetic transcript entries
on-stop.shtakes the last entry of typeuseras the query. But that type also carries background-task notifications, blocking-hook feedback, system reminders, messages from other sessions and subagent prompts, so notifications read:An image-only message carries just
[Image: source: /path], which titled the notification with a file path.Skips synthetic entries and sidechains, strips image markers, falls back to the last real prompt.
Why it matters
Both show up when several Claude Code sessions run in parallel: the notification is the only thing visible from another tab, so a title that names the session's actual task and a body that carries the actual question are the difference between acting on it and switching tabs to find out what happened.
Tests added
Bash,Write,AskUserQuestion, unknown-tool fallback🤖 Generated with Claude Code