updating format of yaml for concept lists - #97
Draft
davidcarlisle wants to merge 33 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft PR to make sure it doesn't accidentally get merged before discussion, however the updated yaml and index files do work and can be viewed at
core: https://davidcarlisle.github.io/mathml-docs/intent-core-concepts/
open: https://davidcarlisle.github.io/mathml-docs/intent-open-concepts/
The diff here isn't very informative as the indentation of the yaml necessarily changed so the diff basically just reports the entire file changed, I'll try to list the main changes here
General Plan:
Move the core and open yaml files to be subsets of the same common yaml format, that is matching the same structure but some fields may not be used in one or other file. With the general structure hopefully close to the format discussed in relation to @dginev 's demos of an editor for the open list.
Core
As before, this has two top level dictionaries
defaultfixityandconceptshowever theconceptsdictionary is no longer subdivided into sections based on subject area, it is now a single collection ofconceptentries, but each concept has asubject-areaentry that allows the HTML display to reconstruct the headings.The language templates under
en:,de:etc are moved down a level under aspeech:entryThe
arityentry is (almost) now redundant and replaced by a list of argument names.Currently the names are just a1, a2, ... for ease of translation but that is not assumed individual entries could use more meaningful names (but see notes below)
so a typical entry is:
Open
The format is as for core except that there is no
defaultfixitydictionary.The one existing section "open concepts" has been removed so as for core, the
conceptsdictionary is now at the top level.The existing
areafield was renamed tosubject-areaand the HTML display sorts the entries based on this field.$1,$2, ... changed toa1,a2, ... as for core.Notes
Most arities use a fixed number and for example
arity: 2is redundant givenarguments: [a1, a2]however some had variable arity such as>=0and>=1and it isn't clear how that can be shown on the argument list, currentlyI could use
[...]for the>=0case, but then there isn't a name to use in the speech templates unless we predefine one?The speech templates used to use
$1and$2etc to denote where the argument should be used in the expression, the current draft uses the names from the argument list. while they area1,a2they are distinguishable from natural language but if more natural argument names were used this might not be the case, egdoes perhaps not make it easy to distinguish the "slots` perhaps they should be explicitly marked
or some such? I updated to use the
$prefix in the current draftthe markup for conditional expressions is a bit unsatisfactory
currently conditional based on the input marked as follows (does not occur in the open list)
Conditional based on user settings is marked as
Extra fields in Open, currently there are several fields in the open list not used in core these could be used in core later but first we should fix the exact list, I think there is a lot of flexibility here, to fit in with whatever works best for the proposed editor.