Repository navigation
remove_cv in writeObjects and readObjects - #1752
Open
AnyOldName3 wants to merge 1 commit into
Open
AnyOldName3 wants to merge 1 commit into
AnyOldName3 wants to merge 1 commit into
Conversation
There's no reason const values shouldn't be serialisable, but matchPropertyName can't handle type names with spaces in, so we can't read them back if we write the `const ` prefix or expect it to be in the name we've read.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
There's no reason
constvalues shouldn't be serialisable, butmatchPropertyNamecan't handle type names with spaces in, so we can't read them back if we write theconstprefix or expect it to be in the name we've read.Type of change
Arguably either a bugfix (it stops something someone might expect to be serialisable from failing to deserialise) or a feature (it makes something deserialisable that wasn't before)
How Has This Been Tested?
I've serialised and deserialised some const values that errored out without this change.