Repository navigation
Add const to variadic write overload - #1751
Open
AnyOldName3 wants to merge 1 commit into
Open
AnyOldName3 wants to merge 1 commit into
AnyOldName3 wants to merge 1 commit into
Conversation
All the write implementations it can call take const pointers, so this shouldn't stop anything from compiling that worked before, but it makes this overload usable in const write implementations (which all of them are) without making a temporary copy of fields.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Add
constto variadicOutput::writeoverloadAll the write implementations it can call take
constpointers, so this shouldn't stop anything from compiling that worked before, but it makes this overload usable inconstwriteimplementations (which all of them are - the base signature isvirtual void write(Output& output) const) without making a temporary copy of fields.Fixes: nothing on the tracker
Type of change
Please delete options that are not relevant.
An argument could be made for this being either a bug fix or a new feature, or even just a typo fix.
How Has This Been Tested?
It still builds, and if it was going to break anything, it would stop it building.
Checklist:
I have commented my code, particularly in hard-to-understand areasN/AI have made corresponding changes to the documentationN/AI have added tests that prove my fix is effective or that my feature worksN/ANew and existing unit tests pass locally with my changesN/AAny dependent changes have been merged and published in downstream modulesN/A