Repository navigation
Parquet bars are teal in posts, and bench hovers and links lose their Blue - #186
Conversation
…, the results source line, and blog excerpts Signed-off-by: Will Manning <will@willmanning.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🔦 Lighthouse audit
Run |
ScreenshotsIn each image, the left side is before (main, the code that production runs). The right side is after (this PR). Each image shows the dark theme and the light theme where the page has both. The images come from local builds. Bench uses a copy of its database. Post figure: the Parquet bar is teal
Bench: the Filter series button on hover has an ink border, not Blue
Bench: the Groups button on hover has an ink border, not Blue
Bench: a group row in the Groups panel shows the wash on hover
Bench: a summary row shows the wash on hover
Bench: the info tooltip has a hairline, not a shadow
Bench: the downsample badge is muted, not Blue
Bench: links are ink at rest, with an underline in text
Site header: the links stay after the wordmarkThis change now comes from main. #188 copied the design system's styles, and the system anchors the links after the wordmark. This PR no longer changes the header: screenshots of main and of this PR are the same, pixel for pixel. In each image, the left side is main before #188 (9567c59), and the right side is the header now. From 801px to 920px, the blog shows the Menu button, as the design system sets.
Homepage: the results source line uses vx-label-sm
Blog index: an excerpt is capped at 54chThis change now comes from main. The design system caps the excerpt at 54ch, and #188 copied that rule. This PR no longer changes the blog index: screenshots of main and of this PR are the same, pixel for pixel. At 1440, most full lines are 70 to 76 characters. In each image, the left side is main before #188 (9567c59), and the right side is the blog index now. The titles are in Geist now, also from #188.
|
At 54ch the excerpt's full lines run 70 to 76 characters (median 72) at 1440 and 1024. At 48ch they held about 64. Signed-off-by: Will Manning <will@willmanning.io>
…ings in Geist Mono (#188) * Code reads like an editor's: Blue keywords, purple functions, teal types, and pink strings Copies the design system's new syntax colours (system v97). Keywords are blue-soft in Dark and blue in Light; functions take a purple tint; the new syntax-type token gives types, classes, and traits a teal tint; strings, numbers, and constants take a pink tint. Code no longer uses the green and orange status hues. Every colour holds 4.96:1 or better on raised. Signed-off-by: Will Manning <will@willmanning.io> * Headings drop Funnel Display: titles in Geist, section headings in Geist Mono The design system has two faces now (Decisions, Made 21). Titles and big figures take --font-display, which is var(--font-sans). A post's section headings and bench's headings are Geist Mono. next/font stops loading Funnel Display, and the share cards set the title in Geist Medium. The recopy also brings the system's skip link, the header's link position, and the 54ch excerpt measure, so #183 and #186 can drop their own rules. Signed-off-by: Will Manning <will@willmanning.io> --------- Signed-off-by: Will Manning <will@willmanning.io>
Signed-off-by: Will Manning <will@willmanning.io>
main's copy of the system's styles now anchors the header links after the wordmark and caps the post-row excerpt at 54ch, so the site's overrides go. Signed-off-by: Will Manning <will@willmanning.io>
lwwmanning
changed the title
This change makes three places match the Vortex design system.
barClass, so each system gets its colour.vx-label-sm.The header and blog excerpt fixes now come from main (#188). The system anchors the header links after the wordmark and caps excerpts at 54ch (most lines 70 to 76 characters). This branch's earlier 48ch held only about 64 characters a line, not 72. This PR has no site rules for them now.
A computed-style comparison of bench's pages shows no other change at rest.
🤖 Generated with Claude Code