Repository navigation
Bench: throughput gains show as gains, partial totals say so, the chart page names its axis unit, Expand all is on the landing page only, and each filter row's "all" clears only that row - #185
Conversation
The tooltip marked every rise as worse. On a throughput chart a rise is a
gain, so the delta's colour now follows higherIsBetter(unit_kind), which
the chart page's description also uses.
The chart page printed the stored unit ("unit: ns") over an axis drawn in
the display unit (ms). It now prints the display unit that the chart picks
from the same values.
Signed-off-by: Will Manning <will@willmanning.io>
A series measured in 20 of 22 queries showed a smaller total beside the complete totals, and only its hover title said why. Its total now reads "(partial)", the word a group's headline uses, in the query, vector search, and random access cards. Signed-off-by: Will Manning <will@willmanning.io>
The chart page, the methodology page, and the loading view have no groups, so the two buttons did nothing there. The landing page now asks for them when it has groups. Signed-off-by: Will Manning <will@willmanning.io>
The Engine, Format, and Series rows all wrote one per-series list, so each row's "all" chip cleared all three. The group store now keeps the Engine and Format choices apart from the Series choices, and each "all" chip clears its own row. A chip shows its own row's choice, so turning a format off leaves the engine chips on. A permalink still names series: it lists every series that any row hides. Signed-off-by: Will Manning <will@willmanning.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🔦 Lighthouse audit
Run |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5bf862dfd2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ScreenshotsThe left column is Partial totals, desktop
Partial totals, phone (375 px)
Axis unit and Expand all, chart page, desktopThe unit line shows
Axis unit and Expand all, chart page, phone (375 px)
Expand all, landing pageThe buttons stay on the landing page.
Expand all, methodology page
Group filter: datafusion and Parquet offIn the TPC-H (NVMe) (SF=1) group, I turned off the datafusion engine and the Parquet format. In the after column, the engine chips show only the Engine row, so
Group filter: then the Format row's "all"Before, "all" in the Format row also showed the datafusion series again, but the datafusion chip stayed off. After, it clears only the Format row, and datafusion stays off.
Tooltip on a time chartNo change here. The tooltip fix applies to throughput charts, and no chart sends throughput today, so no page can show it. This pair shows that time charts still mark a rise as worse.
|
…at they describe An Engine or Format chip now reads only its own row, so the Format row cannot turn an engine's chip off when every series of that engine has the hidden format. A group permalink now carries the Engine and Format rows as `hide-engine` and `hide-format` parameters, not as the series they hid when the link was copied. A link copied before every chart loaded now also hides the series of the charts that load later. The chart page's unit now follows the y-axis. When the full history loads and its older values need a larger unit, the meta line changes with the axis. Signed-off-by: Will Manning <will@willmanning.io>
Signed-off-by: Will Manning <will@willmanning.io>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fd06d10df8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…ine or format When an Engine or Format chip turns on a value that the global filter hides, the group's row now keeps the value in `shownEngines` or `shownFormats`. It no longer adds the series the chip covers at that moment to the Series row. So the choice also shows the series of charts that load later, and a group link carries it as `show-engine` or `show-format`. The row's "all" chip and the group's Reset clear these lists too. Signed-off-by: Will Manning <will@willmanning.io>
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This PR corrects five signals in bench.
hide-engine,hide-format,show-engine, andshow-format, so they also apply to charts that load later.Checks: the bench suite with Postgres, typecheck, Biome, knip, and build.
🤖 Generated with Claude Code