Repository navigation
ci: key the Playwright browser cache on the runner image and installed version - #144
Merged
Merged
Conversation
…d version The cache key was `Linux-playwright-<version>`, with the version read from the package.json range. So the ubuntu-26.04 runners in #116 restored WebKit builds made on ubuntu-24.04, which fail to start without Ubuntu 24's libicudata.so.74. And a lock refresh that installs a newer Playwright than the range's floor would restore browsers for the old version; the cache-hit path never installs new ones. Read the version from the installed package, and add the runner image ($ImageOS, e.g. ubuntu24) to the key. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Will Manning <will@willmanning.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🔦 Lighthouse audit
Run |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Playwright browser cache key was
Linux-playwright-<version>, and it took the version from thepackage.jsonrange. Two problems followed. The Ubuntu 26.04 runners in #116 restored WebKit builds made on Ubuntu 24.04, and WebKit failed to start because it needs Ubuntu 24'slibicudata.so.74. Also, a lock refresh that installs a newer Playwright would restore browsers for the old version, because the cache-hit path does not install browsers.The key now uses the installed Playwright version and the runner image (
$ImageOS, for exampleubuntu24).🤖 Generated with Claude Code