Repository navigation
fix: make MDXRenderer a build error outside server components - #139
Merged
Merged
Conversation
MDXRenderer evaluates velite's compiled MDX with `new Function`. The CSP has no 'unsafe-eval', which is correct only while the eval runs on the server, but nothing enforced that. Import "server-only", which Next.js resolves itself, so importing MDXRenderer from a Client Component fails the build instead of failing at runtime in the browser. Verified: the build passes as is, and a temporary client component that imports MDXRenderer fails the Turbopack build. Fixes #70. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Will Manning <will@willmanning.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
lwwmanning
marked this pull request as ready for review
October 30, 2026 01:02
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🔦 Lighthouse audit
Run |
lwwmanning
added a commit
that referenced
this pull request
Oct 30, 2026
main adds COOP and CORP headers (#140), makes MDXRenderer server-only (#139), locks bench's Vercel CLI (#137), and speeds up bench's cache (#135, #136). CLAUDE.md keeps this branch's globals.css line and takes main's header list. The site and bench checks, Playwright, and verify pass on the merged tree. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Will Manning <will@willmanning.io>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MDXRendererruns blog posts' compiled MDX withnew Function. The CSP does not allow'unsafe-eval', which is correct only while that code runs on the server. Nothing enforced this. The component now importsserver-only, so importing it from a Client Component fails the build. Before, it failed at runtime in the browser. Next.js resolvesserver-onlyitself, so no package is added.The build passes as is. A temporary client component that imported
MDXRendererfailed the Turbopack build. Fixes #70.🤖 Generated with Claude Code