Repository navigation
Deploy the tested web commit and verify its public read paths - #127
Merged
Merged
Conversation
…failure Signed-off-by: Connor Tsui <connor.tsui20@gmail.com> Signed-off-by: Will Manning <will@willmanning.io>
#37 changed the standalone repository's schema-deploy.yml and web-ci.yml, which became bench-schema-deploy.yml and bench-ci.yml in this repository. - bench-schema-deploy prepares the migration interpreter in its own step, so a dependency failure can no longer pass as dry-run drift. A dry run now treats exit 1 as drift and any other non-zero exit as a failure. - bench-ci installs uv and runs the migration-runner tests. The web integration suite now also calls the runner through uv. - uv resolves the runner's Python dependencies when it runs, so both workflows set UV_EXCLUDE_NEWER to 14 days ago, matching the repository's cooldown. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Will Manning <will@willmanning.io>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com> Signed-off-by: Will Manning <will@willmanning.io>
#38 changed the standalone repository's web-deploy.yml and added a shared web-checks action. In this repository: - Push and manual production runs share one concurrency group and never cancel an active run. A newer preview can cancel an older one. - A production deploy requires BENCH_SITE_BASE_URL to be an HTTPS URL. - The build embeds BENCH_BUILD_SHA. After the deploy, verify-web-deploy.mjs checks the build commit, the read paths and CDN caching. - bench-ci runs the script's tests. The web-checks action and the pre-deploy check job are left out: bench CI is a required check on main, so merged code has already passed it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Will Manning <will@willmanning.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
53 tasks done
lwwmanning
marked this pull request as ready for review
October 28, 2026 19:30
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Base automatically changed from
claude/port-bench-37-migration-checks
to
main
October 28, 2026 19:31
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 450275c056
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…deploy-verification # Conflicts: # .github/workflows/bench-ci.yml
Codex pointed out that the port dropped #38's pre-deploy checks. Required PR checks do not cover the deployed commit: main takes squash merges without requiring an up-to-date branch, and Bench CI on main runs beside bench-deploy, not before it. So a merged commit could ship unchecked. Restore Connor's design. Bench CI's steps move into the bench-checks composite action. Bench CI runs it, and bench-deploy runs it in a checks job on the commit it deploys, with the deploy job needing that job. The required merge check docs pointed at develop, the old check name and the old repository. They now describe vortex.dev's main ruleset and the deploy-time check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Will Manning <will@willmanning.io>
🔦 Lighthouse audit
Run |
|
Bench preview for |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port vortex-data/benchmarks-website#38 by Connor Tsui. After each deploy,
verify-web-deploy.mjschecks that/api/healthreports the deployed commit, that typical group and chart responses and the HTML pages load, and that the CDN returns a cache hit. Production is checked on the public domain, and a failed check fails the run. Previews are behind Vercel Authentication, so they report verification as blocked. Push and manual production runs now share one queue. The check passes against current production in 6 seconds.This PR is stacked on #126. The second commit ports Connor's workflow changes into
bench-deploy.ymlandbench-ci.yml. It leaves out his shared check action, because bench CI is already a required check onmain.Part of #113.
🤖 Generated with Claude Code