Skip to content

test(fspy): run node fs tests with Deno#541

Merged
wan9chi merged 1 commit into
mainfrom
test/fspy-deno-node-fs
Jul 13, 2026
Merged

test(fspy): run node fs tests with Deno#541
wan9chi merged 1 commit into
mainfrom
test/fspy-deno-node-fs

Conversation

@wan9chi

@wan9chi wan9chi commented Jul 13, 2026

Copy link
Copy Markdown
Member

Motivation

The shared Node-compatible filesystem tests only covered Node.js, leaving Deno compatibility unverified. Add Deno as a workspace test dependency and run the same ignored node_fs cases against both runtimes on supported targets. Deno does not distribute a musl runtime, so only its generated cases are excluded there while Node coverage remains enabled.

wan9chi commented Jul 13, 2026

Copy link
Copy Markdown
Member Author

@wan9chi wan9chi force-pushed the test/fspy-deno-node-fs branch 2 times, most recently from 14d3c1e to dd85cb5 Compare July 13, 2026 03:36
@wan9chi wan9chi marked this pull request as ready for review July 13, 2026 04:36

wan9chi commented Jul 13, 2026

Copy link
Copy Markdown
Member Author

Merge activity

  • Jul 13, 4:40 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jul 13, 4:45 AM UTC: Graphite couldn't merge this PR because it had merge conflicts.
  • Jul 13, 4:54 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jul 13, 4:54 AM UTC: @wan9chi merged this pull request with Graphite.

@wan9chi wan9chi changed the base branch from fix/fspy-handle-open-reentrancy to graphite-base/541 July 13, 2026 04:40
@wan9chi wan9chi changed the base branch from graphite-base/541 to main July 13, 2026 04:44
Co-authored-by: GPT-5 Codex <codex@openai.com>
@wan9chi wan9chi force-pushed the test/fspy-deno-node-fs branch from dd85cb5 to 9cbf275 Compare July 13, 2026 04:50
@wan9chi wan9chi merged commit 2ba033c into main Jul 13, 2026
16 checks passed
@wan9chi wan9chi deleted the test/fspy-deno-node-fs branch July 13, 2026 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant