Repository navigation
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: acef79bfe1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@fengmk2 I've addressed both review findings and fixed the Git hook test compatibility issue in the latest commits. Lint, tests, E2E, and snapshot checks are now passing. The only remaining failing check is Security Analysis, which reports RUSTSEC-2026-0387 in Could you take another look when you have a chance? |
|
@semimikoh The security report for crypto-bigint is a known issue; you can ignore it, as I’m already following up on it. |
| // https://github.com/typicode/husky/blob/v9.1.7/index.js | ||
| // Unknown versions are deliberately preserved rather than guessing that their | ||
| // dispatcher is safe to abandon. | ||
| const HUSKY_GENERATED_SCRIPT_HASHES: Readonly<Record<string, string>> = { |
There was a problem hiding this comment.
Could we implement this without HUSKY_GENERATED_SCRIPT_HASHES, while still protecting custom hooks and avoiding a version-specific hash allowlist?
Fixes #3264
After migrating from Husky to Vite+ hooks, existing clones retain
core.hooksPath=.husky/_. Bothvp configandvp hooks enableskip installation, leaving the migrated hooks inactive.This change automatically replaces local
.huskyand.husky/_paths when:.husky/.Active Husky setups, custom hook paths, global and worktree-scoped settings, symlinked Husky directories, and hook opt-outs remain protected. Existing Husky files are left unchanged.
Adds regression tests and documents the automatic takeover behavior.
Validation
vp config,vp config --hooks, andvp hooks enable.git diff --checkpassed.Full validation is blocked by local build setup:
vp checkandpnpm test:unitcannot start because the existing native binding lacksdocumentationUrl.serde_yaml.