feat(pm): forward native version commands by jong-kyung · Pull Request #2127 · voidzero-dev/vite-plus

jong-kyung · 2026-07-10T01:27:18Z

Summary

Add vp pm version support by forwarding all arguments to the detected package manager's native version command.
Use <pm> version for npm, pnpm, and Yarn, and bun pm version for Bun.

Closes #2092

Reference
npm : https://docs.npmjs.com/cli/v11/commands/npm-version
Yarn1 : https://classic.yarnpkg.com/lang/en/docs/cli/version/
Yarn berry : https://yarnpkg.com/cli/version
Pnpm : https://pnpm.io/cli/version
Bun : https://bun.com/docs/pm/cli/pm#version

netlify · 2026-07-10T01:27:23Z

✅ Deploy Preview for viteplus-preview canceled.

Name	Link
🔨 Latest commit	`0e08154`
🔍 Latest deploy log	https://app.netlify.com/projects/viteplus-preview/deploys/6a509910da674a00089c5d5e

jong-kyung · 2026-07-10T01:39:01Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 54cb100765

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

jong-kyung · 2026-07-10T02:03:00Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 985c09b9b5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

jong-kyung · 2026-07-10T02:28:02Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7783e09033

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

jong-kyung · 2026-07-10T03:01:15Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b4f218bd5d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

jong-kyung · 2026-07-10T03:27:55Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e62b4dde32

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

jong-kyung · 2026-07-10T04:02:51Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2d88894488

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c6ceed152d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

fengmk2 · 2026-07-10T05:49:30Z

Can you add a snapshot test for each PM to ensure it's actually runnable?

jong-kyung · 2026-07-10T06:09:20Z

Can you add a snapshot test for each PM to ensure it's actually runnable?

Sure, I added: 830db34
(new PTY test feels like magic 🫢)

feat(pm): forward native version commands

54cb100

jong-kyung self-assigned this Jul 10, 2026

chatgpt-codex-connector Bot reviewed Jul 10, 2026

View reviewed changes

Comment thread crates/vite_pm_cli/src/handlers.rs

Comment thread crates/vite_install/src/commands/version.rs Outdated

Comment thread crates/vite_install/src/commands/version.rs Outdated

fix(pm): address version forwarding compatibility feedback

985c09b

chatgpt-codex-connector Bot reviewed Jul 10, 2026

View reviewed changes

Comment thread crates/vite_pm_cli/src/handlers.rs Outdated

Comment thread crates/vite_pm_cli/src/cli.rs Outdated

Comment thread crates/vite_pm_cli/src/handlers.rs Outdated

refactor(pm): model version command options

7783e09

chatgpt-codex-connector Bot reviewed Jul 10, 2026

View reviewed changes

Comment thread crates/vite_install/src/commands/version.rs Outdated

Comment thread crates/vite_install/src/commands/version.rs

fix(pm): position version workspace filters

b4f218b

Merge branch 'main' into feat/pm-version

28b9f9d

chatgpt-codex-connector Bot reviewed Jul 10, 2026

View reviewed changes

Comment thread crates/vite_install/src/commands/version.rs Outdated

Comment thread crates/vite_install/src/commands/version.rs

Comment thread crates/vite_pm_cli/src/cli.rs Outdated

jong-kyung added 2 commits July 10, 2026 12:25

Merge branch 'main' into feat/pm-version

c498b54

fix(pm): normalize version command options

e62b4dd

chatgpt-codex-connector Bot reviewed Jul 10, 2026

View reviewed changes

Comment thread crates/vite_install/src/commands/version.rs Outdated

Comment thread crates/vite_install/src/commands/version.rs

fix(pm): reject unsupported version options

2d88894

chatgpt-codex-connector Bot reviewed Jul 10, 2026

View reviewed changes

Comment thread crates/vite_install/src/commands/version.rs

Comment thread crates/vite_pm_cli/src/handlers.rs

Comment thread crates/vite_pm_cli/src/cli.rs

Merge branch 'main' into feat/pm-version

c6ceed1

jong-kyung marked this pull request as ready for review July 10, 2026 04:40

jong-kyung requested a review from fengmk2 July 10, 2026 04:40

chatgpt-codex-connector Bot reviewed Jul 10, 2026

View reviewed changes

Comment thread crates/vite_install/src/commands/version.rs

jong-kyung added 2 commits July 10, 2026 13:50

fix(pm): reject Bun version JSON output

dad15e7

Merge branch 'main' into feat/pm-version

025b1a8

Merge branch 'main' into feat/pm-version

4c506cb

test(pm): cover version commands across package managers

830db34

jong-kyung added 3 commits July 10, 2026 15:15

test(pm): stabilize Yarn version snapshots

ba07941

Merge branch 'main' into feat/pm-version

e0741cb

test(pm): isolate Yarn telemetry in version snapshots

79cbbdb

fengmk2 reviewed Jul 10, 2026

View reviewed changes

Comment thread crates/vite_cli_snapshots/tests/cli_snapshots/fixtures/pm_version/snapshots/pm_version_npm.md

fengmk2 approved these changes Jul 10, 2026

View reviewed changes

Merge branch 'main' into feat/pm-version

0e08154

fengmk2 merged commit 9d3e77b into voidzero-dev:main Jul 10, 2026
51 checks passed

jong-kyung mentioned this pull request Jul 10, 2026

vp pm version does not work #2092

Closed

4 tasks

jong-kyung deleted the feat/pm-version branch July 10, 2026 09:27

Uh oh!

Conversation

jong-kyung commented Jul 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

netlify Bot commented Jul 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for viteplus-preview canceled.

Uh oh!

jong-kyung commented Jul 10, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jong-kyung commented Jul 10, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jong-kyung commented Jul 10, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

jong-kyung commented Jul 10, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jong-kyung commented Jul 10, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

jong-kyung commented Jul 10, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

fengmk2 commented Jul 10, 2026

Uh oh!

jong-kyung commented Jul 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

jong-kyung commented Jul 10, 2026 •

edited

Loading

netlify Bot commented Jul 10, 2026 •

edited

Loading

jong-kyung commented Jul 10, 2026 •

edited

Loading