You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
docs(rfcs): review RFCs for drift from the implementation #3396
Several RFCs in rfcs/ have drifted from the implementation. voidzero-dev/vite-plus#3383 fixed the .nvmrc part, and listed other gaps it left out:
rfcs/env-command.md: the CLI usage comment # Pin a specific version in current directory (creates .node-version) predates the devEngines.runtime default target.
rfcs/dev-engines.md: the decision table (row 4) lists only --target node-version / --target dev-engines.
These were found while working on one topic, so there are likely more. Some RFCs also mix the original decision with later revisions (e.g. "Breaking revision: unified environments" in rfcs/env-command.md), so it's unclear which parts should track the implementation.
Your Suggestion for Changes
Ideally, the team reviews the RFCs as a whole, since it knows which decisions changed and why. It could also clarify whether RFCs are living specs or historical records — the dev-engines.md decision table was left unchanged in #3383 for that reason.
If that's not feasible, I can continue with follow-up PRs, one topic each.
@liangmiQwQ, following up on your comment here, since replying in the merged PR would be noise.
Activity
hyunbinseo commentedon Nov 9, 2026
@jong-kyung Thanks for assigning, but could the team review the RFCs as a whole first? It's hard for me to decide alone:
Happy to help with PRs once that's settled.
jong-kyung commentedon Nov 9, 2026
@liangmiQwQ knows the
env-command.mdanddev-engines.mdchanges better than I do. Could you take a look?liangmiQwQ commentedon Nov 9, 2026
Okay! I would check when I have time.