Skip to content

docs(rfcs): review RFCs for drift from the implementation #3396

Open

Description

@hyunbinseo

Documentation is

  • Missing
  • Outdated
  • Confusing
  • Not sure

Explain in Detail

Several RFCs in rfcs/ have drifted from the implementation. voidzero-dev/vite-plus#3383 fixed the .nvmrc part, and listed other gaps it left out:

  • rfcs/env-command.md: the CLI usage comment # Pin a specific version in current directory (creates .node-version) predates the devEngines.runtime default target.
  • rfcs/env-command.md: the "Pin Command" section covers Node pins only. --target package-manager isn't mentioned.
  • rfcs/dev-engines.md: the decision table (row 4) lists only --target node-version / --target dev-engines.

These were found while working on one topic, so there are likely more. Some RFCs also mix the original decision with later revisions (e.g. "Breaking revision: unified environments" in rfcs/env-command.md), so it's unclear which parts should track the implementation.

Your Suggestion for Changes

Ideally, the team reviews the RFCs as a whole, since it knows which decisions changed and why. It could also clarify whether RFCs are living specs or historical records — the dev-engines.md decision table was left unchanged in #3383 for that reason.

If that's not feasible, I can continue with follow-up PRs, one topic each.

@liangmiQwQ, following up on your comment here, since replying in the merged PR would be noise.

Relevant Page

https://github.com/voidzero-dev/vite-plus/tree/main/rfcs

Activity

  1. hyunbinseo commented on Nov 9, 2026

    @hyunbinseo
    ContributorAuthor

    @jong-kyung Thanks for assigning, but could the team review the RFCs as a whole first? It's hard for me to decide alone:

    • I don't know which development decisions changed later, or why.
    • I can't determine how to fix the drift — update RFCs as living specs, or keep them as historical records.

    Happy to help with PRs once that's settled.

  2. jong-kyung commented on Nov 9, 2026

    @jong-kyung
    Collaborator

    @liangmiQwQ knows the env-command.md and dev-engines.md changes better than I do. Could you take a look?

  3. added theissue type on Nov 9, 2026
  4. liangmiQwQ commented on Nov 9, 2026

    @liangmiQwQ
    Collaborator

    @liangmiQwQ knows the env-command.md and dev-engines.md changes better than I do. Could you take a look?

    Okay! I would check when I have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

documentationImprovements or additions to documentation

Type

Fields

Priority

None yet

Effort

None yet

Target date

None yet

Start date

None yet

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions