Repository navigation
Robj/cache invalid addresses - #693
Merged
Merged
Conversation
Merge main 8e0f29b, including prefix compression and its MemorySanitizer repairs, into the active invalid-address branch. The merge is conflict-free and preserves the existing checked-address implementation and tests byte for byte. Validation: 303 passing unit executions across GCC debug/release and Clang 19 release-MSan, plus the deterministic debug prefetch-admission functional check. Six existing fault-injection-only executions are skipped. Maintained-source formatting and Git whitespace checks pass. Retain historical performance and progress caveats; this integration does not rerun benchmarks. Archive commands, logs, source/binary hashes, counts, and integration notes. Signed-off-by: Rob Johnson <rob@robjohnson.io>
Keep invalid-address diagnostics cold, validate async allocation only in the existing disk-load coroutine, and use a checked power-of-two alignment mask. Preserve invalid-miss rejection before reservation or I/O and the existing retry, resume, and callback ownership contracts. Record controlled cache and database comparisons against main and the unoptimized branch, including unresolved insertion wall-time variation. Validate the exact source in release, debug and MemorySanitizer builds. Signed-off-by: Rob Johnson <rob@robjohnson.io>
✅ Deploy Preview for splinterdb canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return an error (instead of asserting) on cache_get calls with invalid address arguments.