Conversation
The Windows CI job has been failing on main, not just on branches:
touch/touch_windows.c.v:17:20: error: cannot use �oidptr as u32
in argument 1 to C.SetFileTime
A HANDLE is a pointer. vlib's C.CreateFileW returns voidptr, and used to return
u32, so the u32 in this declaration stopped matching. touch is not in the
Windows ignore list, so the whole Windows build stopped with it.
One word, no behaviour change: the file did not compile, so there was no
behaviour to change.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The \winos-test\ job has been red on \main\ itself, not only on branches, with one error:
\
touch/touch_windows.c.v:17:20: error: cannot use \�oidptr\ as \u32
in argument 1 to \C.SetFileTime
\\
A HANDLE is a pointer. vlib's \C.CreateFileW\ returns \�oidptr\ and used to return \u32, so the \u32\ in this declaration stopped matching what \lutime\ passes it. \ ouch\ is not in the Windows ignore list, so the Windows build stopped with it.
One word, no behaviour change: the file did not compile, so there was no behaviour to change. Verified by building \src/touch\ with V 0.5.2 on Windows, and \� fmt -verify .\ plus \� run build.vsh\ still pass on Linux.