Conversation
Signed-off-by: Dindihub <sadindi03@gmail.com>
Signed-off-by: Dindihub <sadindi03@gmail.com>
Signed-off-by: Dindihub <sadindi03@gmail.com>
Signed-off-by: Dindihub <sadindi03@gmail.com>
Signed-off-by: Dindihub <sadindi03@gmail.com>
Signed-off-by: Dindihub <sadindi03@gmail.com>
Signed-off-by: Dindihub <sadindi03@gmail.com>
Signed-off-by: Dindihub <sadindi03@gmail.com>
Signed-off-by: Dindihub <sadindi03@gmail.com>
Signed-off-by: Dindihub <sadindi03@gmail.com>
Signed-off-by: Dindihub <sadindi03@gmail.com>
Signed-off-by: Dindihub <sadindi03@gmail.com>
Signed-off-by: Dindihub <sadindi03@gmail.com>
Signed-off-by: Dindihub <sadindi03@gmail.com>
Signed-off-by: Dindihub <sadindi03@gmail.com>
Signed-off-by: Dindihub <sadindi03@gmail.com>
Signed-off-by: Dindihub <sadindi03@gmail.com>
|
@mattlord, here is the PR. I can't see the Netlify preview yet. Looks like it needs your approval. |
✅ Deploy Preview for vitess ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
We need to revert the changes to this file as I believe it was for the one you had created
mattlord
left a comment
There was a problem hiding this comment.
Correct me if I'm wrong, but I was assuming this should be lossless reorganization and it doesn't seem to be currently.. The visual direction is reasonable, and the site builds, but the PR currently removes routes, duplicates versioned documentation, introduces broken navigation, and exposes new broken links.
Merge blockers
-
Seven existing FAQ URLs are lost.
These generated successfully on
prodbut are absent from the PR build:/docs/faq/getting-started/overview/- Its six child FAQ pages, including
/what-is-vitess/
The deploy preview sends the old child URL through the catch-all version redirect and ultimately displays a 404. The four old
/docs/releases/...URLs are correctly preserved with aliases, but the moved FAQ pages have no equivalent aliases.Add explicit aliases or Netlify redirects for the overview and every child. A section-level alias will not preserve descendant URLs automatically.
-
The reorganization creates a second, duplicated documentation tree.
The PR copies 419 Markdown files byte-for-byte from v24:
- 7 Overview pages
- 17 Concepts pages
- 91 User Guide pages
- 304 Reference pages
This creates duplicate search results and duplicate crawlable content, and it will drift. In particular, the [generated-reference workflow](
) only updateswebsite/tools/cobradocs/version.go
Lines 32 to 34 in 8cfe093
content/en/docs/<version>/reference/programs; it will never update the new unversioned copies.Given the requirement that this is only a reorganization, I recommend keeping v24 as the single content source and changing the navigation to present its sections at the top level. Do not physically copy the documentation.
-
The forced Netlify rule makes the new User Guide tree unreachable.
These
301!rules forcibly redirect every new/docs/user-guides/...page to/docs/24.0/user-guides/..., even when the unversioned static page exists.On the resulting v24 page, the sidebar has no active or expanded item because version sections are hidden. Thus, clicking the new navigation changes the URL and loses navigation context. Either link the reorganized menu directly to the versioned source tree, or remove the forced redirect and establish explicit canonical/versioning behavior.
-
The new Releases link is broken throughout the Chinese site.
The navbar uses
relLangURL, producing/zh/releases/, but the PR adds only English release content and an English translation key. The live preview’s Chinese navbar shows “Releases,” and the link returns 404.Add localized content and translation, or deliberately link Chinese pages to the English
/releases/fallback. -
Existing versioned pages lose their navigation path.
v23, v24, and v25 are marked
hide_in_sidebar, and [the desktop sidebar filters them out](). Direct visits and inbound links towebsite/layouts/partials/docs/sidebar.html
Lines 5 to 9 in 8cfe093
/docs/24.0/...therefore show no active or expanded sidebar hierarchy.The Releases page does not compensate for this: its version headings are plain text and do not link to
/docs/25.0/,/docs/24.0/, or/docs/23.0/. Preserve usable navigation on versioned URLs and add clear documentation-version links to Releases. -
Moved Markdown contains newly invalid relative paths.
The internal checker reports 42 broken references in the newly added unversioned trees: 38 missing targets and four missing fragments across 21 files.
A clear example is
[content/en/docs/concepts/vtadmin.md:24](https://github.com/vitessio/website/blob/8cfe093d1aac17a79db00e609cea1cabde5b661a/content/en/docs/concepts/vtadmin.md#L24). Its../../../21.0/reference/vtadmin/link worked from the deeper versioned path, but from/docs/concepts/vtadmin/it resolves to/21.0/reference/vtadmin/, which does not exist.Every moved relative link needs auditing. Hugo
ref/relreflinks would be less fragile than directory-depth arithmetic.
UI/UX follow-ups
-
The mobile documentation menu was not reorganized consistently.
) ignoreswebsite/layouts/partials/docs/header.html
Lines 61 to 79 in 8cfe093
hide_in_sidebar, still lists all versions, and then dumps their immediate pages into one dropdown.At 390×844, the menu contains 111 links versus 65 on
prodand is roughly 3,700px tall. It should use the same filtered information architecture as desktop, preferably with nested collapsible sections. -
The promoted Releases page needs Markdown/content cleanup.
- It should link release headings to their corresponding documentation.
- “The latest and current vitess release” is redundant and should capitalize “Vitess.”
- It says v20.0.6 is current, but [v20.0.8 exists](https://github.com/vitessio/vitess/releases/tag/v20.0.8).
- The Get Started introduction repeats “install Vitess locally” awkwardly.
|
Thanks for the detailed review @mattlord Thanks for the suggestions. It clarifies how the navigation works and the intended architecture. I'll work on them one by one. |
Signed-off-by: Dindihub <sadindi03@gmail.com>
Signed-off-by: Dindihub <sadindi03@gmail.com>
Signed-off-by: Dindihub <sadindi03@gmail.com>
|
Hi @mattlord . I have worked on merge blocker no. 2 to start. |
v25 is what will eventually become the v26 docs when we do the first v25 RC. So the v25 docs should be the basis for anything new. If I'm understanding you correctly. |
Got it. I'll make it point to V25.0 instead. Something I would like to understand, do the versioned docs change with each release? I noticed that the three versions had the same docs that's why I initially moved them out of the versions where they are visible. |
Signed-off-by: Dindihub <sadindi03@gmail.com>
Signed-off-by: Dindihub <sadindi03@gmail.com>
Signed-off-by: Dindihub <sadindi03@gmail.com>
|
Merge blocker 1: |
Signed-off-by: Dindihub <sadindi03@gmail.com>
Signed-off-by: Dindihub <sadindi03@gmail.com>
…to Releases Signed-off-by: Dindihub <sadindi03@gmail.com>
Signed-off-by: Dindihub <sadindi03@gmail.com>
Signed-off-by: Dindihub <sadindi03@gmail.com>
Signed-off-by: Dindihub <sadindi03@gmail.com>
|
Hi @mattlord, I believe I have addressed 7 of the 8 merge blockers by returning the versioned docs and some page updates as suggested. Please confirm. Merge blocker 7 may be out of my scope as I don't have much experience with mobile. What would you recommend? Happy to take suggestions. |
Signed-off-by: Dindihub <sadindi03@gmail.com>
mattlord
left a comment
There was a problem hiding this comment.
-
Blocking: I still agree with the existing versioned-navigation concern. The latest changes restore navigation for v25, but v24 and v23 remain hidden in
content/en/docs/24.0/_index.md:10andcontent/en/docs/23.0/_index.md:10. I think hidden versions should still appear when they contain the current page, so direct links into stable documentation retain their hierarchy. -
Blocking: In
content/en/docs/25.0/get-started/_index.md:10, the visible documentation promotes the quickstart, but the corresponding title and ordering changes were only applied to v24. The rendered v25 navigation still lists the Operator first and “Local Install” second. I think we should apply the quickstart title and weights to v25 as well, since that is now the primary documentation tree. -
Blocking: In
content/en/releases/_index.md:53, the initial v20 GA release was changed fromv20.0.0on 2024-06-27 tov20.0.6on 2025-02-12. The patch-release list also skips the existingv20.0.7release. I think we should restore the original GA entry and addv20.0.7to the patch list. -
Non-blocking: I agree that the existing mobile-navigation follow-up remains valid. The latest changes still do not update
layouts/partials/docs/header.html, so mobile continues to use the old version-heavy navigation rather than the new desktop IA. -
Non-blocking:
content/en/docs/contributing/contributing-to-ast-parser.md:4usesweeightrather thanweight. Hugo ignores it, and the Parser and AST page renders last instead of at the intended position. I think we should correct the key toweight: 5.
Fairly manageable. I am currently having issues with my laptop. I'll work on this as soon as its fixed. |
Summary
This PR addresses some of the recommendations in Umbrella issue #1955 . It redesigns the Vitess documentation Information architecture to improve discoverability and navigation for new users.
Changes
-Moved Releases to top-nav
-Moved the versions to Releases/mentions of them
-Added an intro to Docs
-Moved Overview, Get started, Concepts, User guides, and references out of versions into the sidebar
-Renamed the Local install to Quick start guide
-Moved the Blog further right
-Rearranged items in the Contributing guide