fix: unset removed marker style properties - #2601
Open
chrisgervang wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c9fe608. Configure here.
|
|
||
| t.is(div.style.opacity, '0.5', 'does not clear properties it did not apply'); | ||
| t.end(); | ||
| }); |
There was a problem hiding this comment.
Tests use incompatible tape assertions
Medium Severity
The new regression tests call tape-style t.is and t.end, but this suite runs on Vitest and the existing test in the same file uses expect. Vitest's test context has no those methods, so these cases throw at runtime and never validate the unset behavior.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit c9fe608. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fixes #2595 with a fresh implementation of the intent behind #2596 on current master.
Applied style keys are tracked per element; removed or nullish keys are cleared before new values so shorthand transitions work and unrelated inline styles remain untouched.
Mapbox and MapLibre have matching regression coverage for undefined, null, omission, whole-style removal, reapplication, and shorthand/longhand transitions.
Tested with yarn lint, yarn test ci, and both module TypeScript checks.
Note
Low Risk
Localized DOM styling helper change with broad regression tests; no auth, data, or API surface changes.
Overview
applyReactStylenow tracks which style keys it applied per DOM element (via aWeakMap) and clears keys that disappear from the next style object—undefined,null, omission, ornull/undefinedfor the whole style—so marker/control inline styles don’t stick after React updates.The same logic is applied in
react-mapboxandreact-maplibre.null/undefinedstyles are treated as empty updates (only previously managed keys are cleared). Inline properties not set by this helper are left unchanged. Shorthand/longhand transitions (e.g.paddingvspaddingTop) are handled by clearing dropped keys before applying new ones.Regression tests cover unset behavior, shorthand transitions, and unmanaged inline styles in both modules.
Reviewed by Cursor Bugbot for commit c9fe608. Bugbot is set up for automated code reviews on this repo. Configure here.