Add thailint - #3307
Open
be-wise-be-kind wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds thailint to Code Analysis, as the fifth entry against the cap of five.
Disclosure: I maintain it.
Against the contributing criteria
Why it is a challenger rather than a duplicate
The four current entries cover dead code (vulture), wrapping other linters (prospector), repo-wide intelligence (repowise) and cognitive complexity (complexipy). thailint's two distinctive checks are not in any of them:
# noqaand friends added without a stated reason, which is a common way AI-written code quietly silences a linter.The framing is anti-patterns that appear disproportionately in AI-generated code, which is what separates it from the general-purpose analyzers already listed.
On the download ranking: at ~12.9k/month I am well below vulture, prospector and complexipy, so I am proposing this as one of the two challenger slots rather than as an obvious choice. Entirely understand if you would rather hold the slot open.