Repository navigation
1.3.5: skip the app-bundle suite on a Mac that cannot compile SwiftUI - #21
Merged
Merged
Conversation
…ftUI The suite skipped when `swiftc` was absent, which is not the condition that matters. The Command Line Tools ship `swiftc` but not SwiftUI's macro plugins, so on a Mac with no Xcode `@State` never expands and every view in main.swift collapses into errors about assigning to an immutable `self`. Three tests failed, and the failure read as a defect in the menu bar app rather than a missing toolchain. The probe now compiles the smallest view that needs the plugin, and the skip message names Xcode. Also: the README said 836 tests where the suite has 841, and its link row printed `brew install --cask tokenflow` on its own, which fails — the cask lives in this repo's own tap, so the tap command has to come first. The row points at the Install section, which carries both lines. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
npm testfailed on this machine with three failures intest/bundle.test.js, each reported asmain.swift:1451: cannot assign to property: 'self' is immutable. That reads as a defect in themenu bar app. It is not one.
The real error is the one above it:
external macro implementation type 'SwiftUIMacros.StateMacro' could not be found. The Command Line Tools shipswiftcbut not SwiftUI's macro plugins, so on aMac with no Xcode
@Statenever expands,hoveredbecomes a plain stored property, and everyassignment to it from an escaping closure is a mutation of an immutable captured
self.The suite's
canBuild()guard only asked whetherswiftcexists, so it ran anyway and failed.It now compiles the smallest view that needs the plugin, and skips with a message that names Xcode.
The shipped app is unaffected — CI builds it on a runner with the full toolchain, and the 1.3.4 DMG
verifies against the cask's checksum.
Also
brew install --cask tokenflowon its own, which fails: the casklives in this repo's own tap, so
brew tap vimoxshah/tap …has to come first. The row now pointsat the Install section, which carries both lines.
Gates
npm testnpm run lintnpm run typechecknpm run design:check🤖 Generated with Claude Code