fix: recognize Opus audio sources by extension - #1865
Open
ArianMoeini wants to merge 1 commit into
Open
ArianMoeini wants to merge 1 commit into
ArianMoeini wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related
Addresses #1854.
Description
Recognize
.opusURLs as audio sources, including URLs with query parameters. This lets source selection choose the audio provider before falling back to a HEAD response whose MIME type may be missing or incorrect. The change is limited to Opus; the separate.oggclassification raised in the issue discussion is left for its own decision.Ready?
Yes. The new regression test failed before the fix and passes now. Vidstack's full package suite passes (64 tests across 15 files), as do the package type check and formatting check.
Anything Else?
I verified source classification locally; I did not test playback with the reporter's remote Opus file.
Review Process
Please confirm
.opusURLs select the audio provider in the reporter's reproduction and on a browser that supports the file's codec.