Repository navigation
--ci ignores failUnder from .vcqa.json and always uses 60 #108
Description
Problem
src/cli.ts:699 resolves the exit threshold as flags.failUnder ?? (ciMode ? 60 : config.failUnder ?? 0). Under --ci, a failUnder in .vcqa.json / package.json#vcqa is ignored and 60 is used instead, contradicting the config docs at src/config.ts:11.
Effect: a project that sets failUnder: 80 in config and runs vcqa --ci passes at 61; a project that sets failUnder: 40 fails at 59.
Scope
- Precedence:
--fail-underflag → configfailUnder→--cidefault 60 → 0. - Print the effective threshold and its source (
flag/config/ci default) in the CI summary line.
Acceptance criteria
-
--ciwith configfailUnder: 80and score 70 exits 1; with configfailUnder: 40and score 50 exits 0. -
--fail-understill overrides both. - Docs PR on vibecodeqa/vibecodeqa if
docs/docs/configuration.mdordocs/docs/ci.mdstate the precedence.
Related
#101 (gate-integrity flags failUnder being lowered; the threshold has to be honoured for that to matter).
🤖 Filed with Claude Code
Activity
serge-ivo commentedon Oct 5, 2026
Delivered in #109 (branch
fix/108-ci-fail-under, commit b4503a7). Precedence is now--fail-under→ configfailUnder→--ci60 → 0, resolved in a puresrc/fail-under.ts. CI output names the source, e.g.Passing: score 72 ≥ 80 (config).Verified:
pnpm buildis clean;pnpm linthas 0 errors (62 warnings, same as main);pnpm testpasses 748/748. The new end-to-end tests cover config above 60 failing under--cion a score the old code passed, config below 60 passing, and--fail-underoverriding config.Docs: vibecodeqa/vibecodeqa#57. Merge it after this ships in a release.
This stays open until #109 is merged.
docs(reference): --ci honours config failUnder (vibecodeqa/cli#108)
test(ci): prove config failUnder clears a sub-60 score under --ci (#108)
fix(init): put the scaffolded CI gate in .vcqa.json, not a flag (#108)
docs(ci): fix the impossible gate example; date the precedence check (v…
docs(config): failUnder 0 means no gate; .vcqa.json wins over package…
Merge pull request #109 from vibecodeqa/fix/108-ci-fail-under