Improved selection state for no-geometry frames - #897
Open
Micheal Parks (micheal-parks) wants to merge 2 commits into
Open
Improved selection state for no-geometry frames#897Micheal Parks (micheal-parks) wants to merge 2 commits into
Micheal Parks (micheal-parks) wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: 9595dfb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Micheal Parks (micheal-parks)
requested review from
Devin T. Currie (DTCurrie),
Matthew MacFarquhar (mattmacf98) and
Marcus (sucrammal)
July 29, 2026 20:58
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Currently whenever we select an item in the scene we render a black bounding box over it. This makes sense for just about everything except for axes helpers... which we still draw a bounding box around. This obscures the axes helper and presents confusing information, in reality these frames have no volume.
This PR changes selection state for no-geometry components so that the axes helper is rendered more thickly and with no depth testing - placing it on top all other scene objects, giving it a clear selection state, and one that makes a bit more sense than the current scenario.