Skip to content

Motion plan replay: world_state obstacles - #895

Open
Marcus (sucrammal) wants to merge 4 commits into
mpr-prismaticfrom
mpr-world-state
Open

Motion plan replay: world_state obstacles#895
Marcus (sucrammal) wants to merge 4 commits into
mpr-prismaticfrom
mpr-world-state

Conversation

@sucrammal

@sucrammal Marcus (sucrammal) commented Jul 29, 2026

Copy link
Copy Markdown
Member

Issue

Parsed plans dropped world_state, so obstacles and attached transforms never appeared in client-side replay. world-state-obstacles.ts decodes WorldState via fromJson (ignoreUnknownFields) and emits one stable obstacle: transform per geometry, shared across steps for reconcile.

Changes

  • Keeps world_state on ParsedPlan, adds world-state-obstacles.ts, and merges obstacle transforms in plan-to-snapshots with naming mirrored for world_state transforms
  • Tests: Adds pirouette-request.json and world-state-obstacles.spec.ts covering decode, uuid stability, and snapshot emission

Testing

  1. Open localhost:5173, upload pirouette-request.json, scrub → world_state obstacles/transforms render and stay keyed across steps
  2. Upload plan.json and salad-plan.json, scrub → unchanged from lower layers, console silent

Stack created with GitHub Stacks CLIGive Feedback 💬

@changeset-bot

changeset-bot Bot commented Jul 29, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 702056a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@viamrobotics/motion-tools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sucrammal Marcus (sucrammal) changed the title mpr world state Motion plan replay: world_state obstacles Jul 29, 2026
@github-actions

github-actions Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://viamrobotics.github.io/visualization/pr-preview/pr-895/

Built to branch gh-pages at 2026-07-29 21:25 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@sucrammal
Marcus (sucrammal) marked this pull request as ready for review July 29, 2026 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant