Skip to content

Motion plan replay: Support translational / prismatic joints - #894

Open
Marcus (sucrammal) wants to merge 3 commits into
mpr-orient-warnfrom
mpr-prismatic
Open

Motion plan replay: Support translational / prismatic joints#894
Marcus (sucrammal) wants to merge 3 commits into
mpr-orient-warnfrom
mpr-prismatic

Conversation

@sucrammal

@sucrammal Marcus (sucrammal) commented Jul 29, 2026

Copy link
Copy Markdown
Member

Issue

Client-side FK treated every joint as revolute, so gantries and parallel-jaw grippers never translated in replay. JointFrameDescriptor now carries a motion discriminator and computeJointPose reads translational steps as millimetres along the joint axis.

Changes

  • Adds rotational|translational motion on JointFrameDescriptor and millimetre prismatic FK in computeJointPose
  • Config: Ignores the whole MotionPlanReplayer fixtures directory in .prettierignore (captures are intentionally invalid JSON)
  • Tests: Adds gantry-plan.json and asserts the carriage slides along X across steps

Testing

  • Open localhost:5173, upload gantry-plan.json, scrub → carriage box slides 40mm along X (on main it stays motionless because the arm holds zero)
  • Upload plan.json and salad-plan.json, scrub → unchanged from the layer below, console silent

Stack created with GitHub Stacks CLIGive Feedback 💬

@changeset-bot

changeset-bot Bot commented Jul 29, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 30d6564

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@viamrobotics/motion-tools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actions Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://viamrobotics.github.io/visualization/pr-preview/pr-894/

Built to branch gh-pages at 2026-07-29 21:25 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@sucrammal
Marcus (sucrammal) marked this pull request as ready for review July 29, 2026 20:43
@sucrammal Marcus (sucrammal) changed the title mpr prismatic Motion plan replay: Support translational / prismatic joints Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant