Motion plan replay: axis_angles + warn on skipped frames/orients - #893
Open
Marcus (sucrammal) wants to merge 5 commits into
Open
Motion plan replay: axis_angles + warn on skipped frames/orients#893Marcus (sucrammal) wants to merge 5 commits into
Marcus (sucrammal) wants to merge 5 commits into
Conversation
🦋 Changeset detectedLatest commit: a9d5b11 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Marcus (sucrammal)
changed the title
Contributor
|
Marcus (sucrammal)
marked this pull request as ready for review
July 29, 2026 20:43
Marcus (sucrammal)
requested review from
Devin T. Currie (DTCurrie) and
Matthew MacFarquhar (mattmacf98)
July 29, 2026 20:44
- Warn when an orientation encoding is unrecognized - Handle axis_angles type (RDK)
Marcus (sucrammal)
force-pushed
the
mpr-orient-warn
branch
from
July 29, 2026 21:24
faad5ed to
a9d5b11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Unrecognized orientation encodings in the client-side frame fallback silently became identity rotations, and unregistered frame types disappeared without a console signal. quatFromJson now accepts RDK axis_angles, validates encodings once, and warns (naming the frame) when orients or frame types are skipped.
Changes
Testing
Stack created with GitHub Stacks CLI • Give Feedback 💬