RSDK-13976 Implement PlayStream - #1216
Merged
Merged
Conversation
oliviamiller
marked this pull request as ready for review
May 19, 2026 18:04
oliviamiller
requested review from
Allison Chiang (allisonschiang) and
lia (lia-viam)
May 19, 2026 18:04
Naveed Jooma (njooma)
requested changes
May 20, 2026
Naveed Jooma (njooma)
left a comment
Naveed Jooma (njooma)
left a comment
Member
There was a problem hiding this comment.
This looks good! Only change requested: remove the generated protobuf messages and pull from main (the methods should be merged in by now)
Member
|
oliviamiller status on this? Still needed? |
oliviamiller
requested review from
Naveed Jooma (njooma) and
Sean Pollock (seanavery)
and removed request for
Allison Chiang (allisonschiang)
July 24, 2026 13:39
Member
Author
Yes thanks for bump still should be merged, just made requested changes. |
Sean Pollock (seanavery)
approved these changes
Jul 24, 2026
Naveed Jooma (njooma)
approved these changes
Jul 29, 2026
Comment on lines
+57
to
+58
| info: AudioInfo, | ||
| chunks: AsyncIterable[bytes], |
There was a problem hiding this comment.
Swapping the order like this is a breaking change just FYI, but I think it's OK since you're probably the only one using it
Member
Author
There was a problem hiding this comment.
Yeah I wanted it to match the order on the other SDKs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement PlayStream wrapper in audio out component.
Doc: https://docs.google.com/document/d/1j3HqaDqhk1mVqKixENFzowqhgbtsjFvXtl8IejE3pHw/edit?tab=t.0