feat: select semantic text typefaces - #335
Open
Happypig375 wants to merge 6 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IEnumerable<Typeface>behavior from Honor styles in local text typefaces #284 and descriptor state through absolute/relative size changesTesting
SemanticTypefaceDescriptorTests: 10 passed, including Source Serif Proa→ genuineA.scglyph 1108 and its distinct advanceTestStyledLocalTypefaces: 6 passedTextLaTeXParserTests: 241 passed;TextStyleTests: 17 passedStack
This PR is based on
issue-306-semantic-text-style/ #331 and merges the styled-local-typeface prerequisite from #284. GitHub issue dependencies record both #306 and #142 as blockers.Closes #307
CI hardening
A transient Windows failure exposed concurrent lazy mutation in the vendored cmap lookup while semantic font selection exercised shared typefaces. Glyph lookup is now serialized per
Typefacethrough a weak-keyed lock, covering every reachable cmap call without globally serializing unrelated faces.The regression test starts eight long-running workers behind a barrier, uses distinct code points to force concurrent cache growth, retains and validates all 2,048 observations, and has a five-second linked deadline. It passed three independent focused runs; the previously failing AngouriMath modulo class also passed.